Skip to content

upgrade go to 1.25.0#16537

Closed
NemilShah007 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
NemilShah007:upgrade-dependencies
Closed

upgrade go to 1.25.0#16537
NemilShah007 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
NemilShah007:upgrade-dependencies

Conversation

@NemilShah007
Copy link
Copy Markdown
Contributor

@NemilShah007 NemilShah007 commented Feb 26, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

upgraded go to 1.25.0

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from SirGitsalot February 26, 2026 06:31
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 18 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 2 files changed, 18 insertions(+), 18 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6088
Passed tests: 5450
Skipped tests: 636
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
  • TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Copy Markdown
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need Go 1.25 specifically, or does one of the new dependencies require it? It's actually kind of a PITA to upgrade the version of Go in Magic Modules (for reference, here's the PR that upgraded to 1.24)

@NemilShah007
Copy link
Copy Markdown
Contributor Author

This is no longer needed. Thanks for your review.

@NemilShah007 NemilShah007 deleted the upgrade-dependencies branch March 3, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants