Skip to content

Add mode field to Storage Pool#16563

Merged
c2thorn merged 1 commit intoGoogleCloudPlatform:mainfrom
riteshghorse:mode-field
Mar 3, 2026
Merged

Add mode field to Storage Pool#16563
c2thorn merged 1 commit intoGoogleCloudPlatform:mainfrom
riteshghorse:mode-field

Conversation

@riteshghorse
Copy link
Copy Markdown
Contributor

netapp: added additional field `mode` in `google_netapp_storage_pool` resource

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from c2thorn February 27, 2026 06:14
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+))
google-beta provider: Diff ( 4 files changed, 120 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+))
google-beta provider: Diff ( 4 files changed, 120 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 40
Passed tests: 39
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_ontapMode

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 40
Passed tests: 39
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappStoragePool_ontapMode

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_ontapMode [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappStoragePool_ontapMode [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@c2thorn c2thorn added this pull request to the merge queue Mar 3, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 201fed5 Mar 3, 2026
23 checks passed
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants