Skip to content

Migrated from BasePath to explicit product usage for all services#17656

Open
melinath wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
melinath:remove-basepath-2
Open

Migrated from BasePath to explicit product usage for all services#17656
melinath wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
melinath:remove-basepath-2

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented May 20, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 20, 2026 •
edited
Loading

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b6cae05:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 123 files changed, 211 insertions(+), 208 deletions(-)
google-beta provider View Diff 123 files changed, 211 insertions(+), 208 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
3376 3122 250 4
Affected Service Packages
  • containeraws
  • deploymentmanager
  • kms
  • tags
  • backupdr
  • osconfig
  • siteverification
  • vmwareengine
  • cloudquotas
  • compute
  • containerattached
  • containerazure
  • discoveryengine
  • eventarc
  • iam2
  • networksecurity
  • alloydb
  • bigquerydatatransfer
  • ces
  • chronicle
  • dns
  • privateca
  • secretmanager
  • apphub
  • bigquery
  • composer
  • dataplex
  • documentaiwarehouse
  • gkehub
  • gkehub2
  • integrationconnectors
  • artifactregistry
  • cloudids
  • logging
  • networkmanagement
  • networkservices
  • sourcerepo
  • storage
  • vertexai
  • identityplatform
  • oracledatabase
  • resourcemanager
  • secretmanagerregional
  • securitycenter
  • storagetransfer
  • datastream
  • monitoring
  • netapp
  • orgpolicy

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDataSourceVertexAIIndex_basic
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccSourceRepoRepositoryIamMemberGenerated

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ✅ TestAccDataSourceVertexAIIndex_basic
✅ Log ✅ TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccSourceRepoRepositoryIamMemberGenerated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for b6cae05!

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 21, 2026

Failures in replaying only:

  • TestAccDataSourceVertexAIIndex_basic looks like it's due to a bug in ReplaceVarsForTest where base paths containing locations weren't being built properly; this PR fixes the bug. Since the test passed in VCR and it's a test-only change we should be good.
  • TestAccProjectIamMemberRemove_memberInMultipleBindings has URLs that look correct and it doesn't look like anything involved in this test was changed by this PR. Should be okay.

Failures in recording are both happening on all PRs right now, for example #17607

@melinath melinath requested a review from SirGitsalot May 21, 2026 15:25
melinath
melinath commented May 21, 2026
View reviewed changes
Comment thread mmv1/third_party/terraform/services/gkehub/data_source_google_gke_hub_membership_test.go

config := acctest.GoogleProviderConfig(t)
url, err := tpgresource.ReplaceVarsForTest(config, rs, "{{GKEHub2BasePath}}projects/{{project}}/locations/{{location}}/memberships/{{membership_id}}")
url, err := tpgresource.ReplaceVarsForTest(config, rs, transport_tpg.BaseUrl(gkehub.Product, config)+"projects/{{project}}/locations/{{location}}/memberships/{{membership_id}}")
Copy link
Copy Markdown
Member Author

@melinath melinath May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change from GKEHub2 to GKEHub, but those are identical by default and this is a test-only change, so it should be safe (and VCR results indicate that it is).

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026 •
edited
Loading

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 857b900:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 123 files changed, 211 insertions(+), 208 deletions(-)
google-beta provider View Diff 123 files changed, 211 insertions(+), 208 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
3378 3126 250 2
Affected Service Packages
  • integrationconnectors
  • kms
  • artifactregistry
  • bigquerydatatransfer
  • ces
  • cloudids
  • containerazure
  • dataplex
  • discoveryengine
  • containerattached
  • containeraws
  • deploymentmanager
  • dns
  • gkehub
  • iam2
  • netapp
  • bigquery
  • cloudquotas
  • monitoring
  • orgpolicy
  • privateca
  • secretmanagerregional
  • eventarc
  • gkehub2
  • logging
  • networksecurity
  • secretmanager
  • siteverification
  • storage
  • tags
  • identityplatform
  • chronicle
  • networkmanagement
  • securitycenter
  • sourcerepo
  • storagetransfer
  • vmwareengine
  • apphub
  • composer
  • compute
  • networkservices
  • osconfig
  • alloydb
  • datastream
  • documentaiwarehouse
  • oracledatabase
  • resourcemanager
  • vertexai
  • backupdr

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccSourceRepoRepositoryIamMemberGenerated

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccSourceRepoRepositoryIamMemberGenerated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath, @SirGitsalot VCR tests complete for 857b900!

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 21, 2026

VCR failures still look unrelated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SirGitsalot SirGitsalot SirGitsalot approved these changes

Assignees

No one assigned

Labels

service/terraform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melinath @modular-magician @SirGitsalot