Add Chronicle Findings Refinement to terraform#17659
Conversation
nimam
commented
May 20, 2026
On branch chronicle-findings-refinement-naef
Changes to be committed:
new file: mmv1/products/chronicle/FindingsRefinement.yaml
new file: mmv1/templates/terraform/examples/chronicle_findings_refinement_basic.tf.tmpl
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
slevenick
left a comment
There was a problem hiding this comment.
Please add an update test with the new samples system: https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-acceptance-test
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ec5f88a: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_findings_refinement" "primary" {
findings_refinement_id = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @nimam, @ankitgoyal0301 VCR tests complete for ec5f88a! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 30eda66: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_findings_refinement" "primary" {
findings_refinement_id = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @nimam, @ankitgoyal0301 VCR tests complete for 30eda66! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5d07d40: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_findings_refinement" "primary" {
findings_refinement_id = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @nimam, @slevenick, @ankitgoyal0301 VCR tests complete for 5d07d40! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 86fa437: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_findings_refinement" "primary" {
findings_refinement_id = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @nimam, @slevenick, @ankitgoyal0301 VCR tests complete for 86fa437! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b08b38a: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_findings_refinement" "primary" {
findings_refinement_id = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @nimam, @slevenick, @ankitgoyal0301 VCR tests complete for b08b38a! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d868e9e: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @nimam, @slevenick, @ankitgoyal0301 VCR tests complete for d868e9e! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ec7405c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @nimam, @slevenick, @ankitgoyal0301 VCR tests complete for ec7405c! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8c6c3cd: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_findings_refinement" "primary" {
findings_refinement_id = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @nimam, @slevenick, @ankitgoyal0301 VCR tests complete for 8c6c3cd! |