Skip to content

Add Chronicle Findings Refinement to terraform#17659

Open
nimam wants to merge 9 commits into
GoogleCloudPlatform:mainfrom
nimam:chronicle-findings-refinement-naef
Open

Add Chronicle Findings Refinement to terraform#17659
nimam wants to merge 9 commits into
GoogleCloudPlatform:mainfrom
nimam:chronicle-findings-refinement-naef

Conversation

@nimam
Copy link
Copy Markdown

@nimam nimam commented May 20, 2026

`google_chronicle_findings_refinement`

On branch chronicle-findings-refinement-naef
Changes to be committed:
    new file:   mmv1/products/chronicle/FindingsRefinement.yaml
	new file:   mmv1/templates/terraform/examples/chronicle_findings_refinement_basic.tf.tmpl
@github-actions github-actions Bot requested a review from slevenick May 20, 2026 23:48
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Copy Markdown
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an update test with the new samples system: https://googlecloudplatform.github.io/magic-modules/test/test/#add-an-acceptance-test

Comment thread mmv1/products/chronicle/FindingsRefinement.yaml
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 20, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ec5f88a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 195 insertions(+)
google-beta provider View Diff 4 files changed, 1084 insertions(+)
terraform-google-conversion View Diff 1 file changed, 202 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_findings_refinement (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_findings_refinement" "primary" {
  findings_refinement_id = # value needed
}

Test report

Analytics

Total Tests Passed Skipped Affected
39 37 1 1
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nimam, @ankitgoyal0301 VCR tests complete for ec5f88a!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 30eda66:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 195 insertions(+)
google-beta provider View Diff 4 files changed, 1084 insertions(+)
terraform-google-conversion View Diff 1 file changed, 202 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_findings_refinement (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_findings_refinement" "primary" {
  findings_refinement_id = # value needed
}

Test report

Analytics

Total Tests Passed Skipped Affected
39 37 1 1
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nimam, @ankitgoyal0301 VCR tests complete for 30eda66!

@github-actions github-actions Bot requested a review from slevenick May 21, 2026 00:12
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5d07d40:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 213 insertions(+)
google-beta provider View Diff 4 files changed, 1189 insertions(+)
terraform-google-conversion View Diff 1 file changed, 202 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_findings_refinement (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_findings_refinement" "primary" {
  findings_refinement_id = # value needed
}

Test report

Analytics

Total Tests Passed Skipped Affected
40 37 1 2
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample
  • TestAccChronicleFindingsRefinement_chronicleFindingsRefinementUpdateExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample
❌ Error · Log - TestAccChronicleFindingsRefinement_chronicleFindingsRefinementUpdateExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nimam, @slevenick, @ankitgoyal0301 VCR tests complete for 5d07d40!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 86fa437:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 213 insertions(+)
google-beta provider View Diff 4 files changed, 1189 insertions(+)
terraform-google-conversion View Diff 1 file changed, 202 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_findings_refinement (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_findings_refinement" "primary" {
  findings_refinement_id = # value needed
}

Test report

Analytics

Total Tests Passed Skipped Affected
40 37 1 2
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample
  • TestAccChronicleFindingsRefinement_chronicleFindingsRefinementUpdateExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample
❌ Error · Log - TestAccChronicleFindingsRefinement_chronicleFindingsRefinementUpdateExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nimam, @slevenick, @ankitgoyal0301 VCR tests complete for 86fa437!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b08b38a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 213 insertions(+)
google-beta provider View Diff 4 files changed, 1190 insertions(+)
terraform-google-conversion View Diff 1 file changed, 202 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_findings_refinement (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_findings_refinement" "primary" {
  findings_refinement_id = # value needed
}

Test report

Analytics

Total Tests Passed Skipped Affected
40 37 1 2
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample
  • TestAccChronicleFindingsRefinement_chronicleFindingsRefinementUpdateExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccChronicleFindingsRefinement_chronicleFindingsRefinementBasicExample
✅ Log TestAccChronicleFindingsRefinement_chronicleFindingsRefinementUpdateExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@nimam, @slevenick, @ankitgoyal0301 VCR tests complete for b08b38a!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d868e9e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 213 insertions(+)
google-beta provider View Diff 4 files changed, 1188 insertions(+)
terraform-google-conversion View Diff 1 file changed, 202 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
40 39 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@nimam, @slevenick, @ankitgoyal0301 VCR tests complete for d868e9e!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ec7405c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 213 insertions(+)
google-beta provider View Diff 4 files changed, 1188 insertions(+)
terraform-google-conversion View Diff 1 file changed, 202 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
40 39 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@nimam, @slevenick, @ankitgoyal0301 VCR tests complete for ec7405c!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8c6c3cd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 213 insertions(+)
google-beta provider View Diff 4 files changed, 1190 insertions(+)
terraform-google-conversion View Diff 1 file changed, 202 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_findings_refinement (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_findings_refinement" "primary" {
  findings_refinement_id = # value needed
}

Test report

Analytics

Total Tests Passed Skipped Affected
40 39 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@nimam, @slevenick, @ankitgoyal0301 VCR tests complete for 8c6c3cd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants