Skip to content

Migrated resource compute instance from machine image#17661

Open
jcromanu wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
jcromanu:resource_compute_instance_from_machine_image
Open

Migrated resource compute instance from machine image#17661
jcromanu wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
jcromanu:resource_compute_instance_from_machine_image

Conversation

@jcromanu
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `google_compute_instance_from_machine_image`  to use direct HTTP rather than a client library

@github-actions github-actions Bot requested a review from NickElliot May 21, 2026 01:49
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6f99d0e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google-beta provider View Diff 1 file changed, 73 insertions(+), 75 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1452 1347 93 12
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata
  • TestAccComputeInstanceFromMachineImage_IgmpQuery_v2
  • TestAccComputeInstanceFromMachineImage_VSSWindows
  • TestAccComputeInstanceFromMachineImage_basic
  • TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImage_maxRunDuration
  • TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript
  • TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
  • TestAccComputeInstanceFromMachineImage_withSourceMachineImageEncryptionKey

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata
✅ Log TestAccComputeInstanceFromMachineImage_IgmpQuery_v2
✅ Log TestAccComputeInstanceFromMachineImage_VSSWindows
✅ Log TestAccComputeInstanceFromMachineImage_basic
✅ Log TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
✅ Log TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromMachineImage_maxRunDuration
✅ Log TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript
✅ Log TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
✅ Log TestAccComputeInstanceFromMachineImage_withSourceMachineImageEncryptionKey
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @NickElliot VCR tests complete for 6f99d0e!

@jcromanu jcromanu marked this pull request as draft May 21, 2026 15:56
@jcromanu jcromanu force-pushed the resource_compute_instance_from_machine_image branch from 6f99d0e to 8ffaf8f Compare May 21, 2026 19:43
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8ffaf8f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google-beta provider View Diff 2 files changed, 84 insertions(+), 77 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1456 1359 93 4
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @NickElliot VCR tests complete for 8ffaf8f!

@jcromanu jcromanu force-pushed the resource_compute_instance_from_machine_image branch from 8ffaf8f to 273af8e Compare May 21, 2026 21:31
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 273af8e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google-beta provider View Diff 1 file changed, 73 insertions(+), 75 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1456 1361 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @NickElliot VCR tests complete for 273af8e!

@jcromanu jcromanu force-pushed the resource_compute_instance_from_machine_image branch from 273af8e to 75c3e74 Compare May 22, 2026 02:40
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 22, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 75c3e74:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google-beta provider View Diff 2 files changed, 83 insertions(+), 76 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1363 93 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @NickElliot VCR tests complete for 75c3e74!

@jcromanu jcromanu force-pushed the resource_compute_instance_from_machine_image branch from 75c3e74 to a21550d Compare May 22, 2026 06:53
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 22, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a21550d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google-beta provider View Diff 2 files changed, 96 insertions(+), 76 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1363 93 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @NickElliot VCR tests complete for a21550d!

@jcromanu jcromanu force-pushed the resource_compute_instance_from_machine_image branch from a21550d to 2870935 Compare May 22, 2026 21:14
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 22, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2870935:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google-beta provider View Diff 1 file changed, 95 insertions(+), 75 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1353 93 11
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata
  • TestAccComputeInstanceFromMachineImage_IgmpQuery_v2
  • TestAccComputeInstanceFromMachineImage_VSSWindows
  • TestAccComputeInstanceFromMachineImage_basic
  • TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
  • TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImage_maxRunDuration
  • TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript
  • TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
  • TestAccComputeInstanceFromMachineImage_withSourceMachineImageEncryptionKey

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata
✅ Log TestAccComputeInstanceFromMachineImage_IgmpQuery_v2
✅ Log TestAccComputeInstanceFromMachineImage_VSSWindows
✅ Log TestAccComputeInstanceFromMachineImage_basic
✅ Log TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
✅ Log TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromMachineImage_maxRunDuration
✅ Log TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript
✅ Log TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
✅ Log TestAccComputeInstanceFromMachineImage_withSourceMachineImageEncryptionKey

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @NickElliot VCR tests complete for 2870935!

@jcromanu jcromanu marked this pull request as ready for review May 22, 2026 22:14
@jcromanu
Copy link
Copy Markdown
Contributor Author

@NickElliot ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants