compute: remove compute library usage from resource_compute_image_test#17664
Draft
GitOleksandrBokov wants to merge 3 commits into
Draft
compute: remove compute library usage from resource_compute_image_test#17664GitOleksandrBokov wants to merge 3 commits into
GitOleksandrBokov wants to merge 3 commits into
Conversation
Read the image from the SendRequest response as map[string]interface{} instead of unmarshaling into compute.Image, dropping the google.golang.org/api/compute and encoding/json imports.
modular-magician
added
the
awaiting-approval
After removing the compute import the file has no Go template syntax left, so TestTemplatesStillNeedToBeTemplates flags it. Drop the .tmpl extension (cf. GoogleCloudPlatform#17648); it is now a plain handwritten test copied verbatim.
Sort imports and fix struct field alignment so the now-plain .go handwritten file passes run-gofmt; the generator previously applied this formatting only to generated output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the remaining
google.golang.org/api/compute(and the now-unusedencoding/json) usage fromresource_compute_image_test.go.tmpl, completing its move off the Apiary client.testAccCheckComputeImageExistsnow reads the image directly from thetransport_tpg.SendRequestresponse (map[string]interface{}) instead of unmarshaling intocompute.Image, and the label / shielded-state / source-type check helpers read their fields from the map. No behavior change — theSendRequestcalls were already in place; only the residualcompute.Imagetype usage is removed.