compute: remove compute library usage from resource_compute_instance_group#17665
Draft
GitOleksandrBokov wants to merge 1 commit into
Draft
Conversation
…group Flatten named ports directly from the SendRequest response map instead of round-tripping through compute.NamedPort, dropping the google.golang.org/api/compute import.
modular-magician
added
the
awaiting-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the remaining
google.golang.org/api/computeusage fromresource_compute_instance_group.go.tmpl, completing its move off the Apiary client.The Read path now flattens named ports directly from the
transport_tpg.SendRequestresponse map instead of round-tripping throughcompute.NamedPort;flattenNamedPortsnow takes the raw response value. No behavior change — CRUD already usedSendRequest; only the residualcompute.NamedPorttype usage is removed.