Skip to content

compute: add list resources for firewall, subnetwork, global_address#17668

Open
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:add-compute-network-list-resources
Open

compute: add list resources for firewall, subnetwork, global_address#17668
BBBmau wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:add-compute-network-list-resources

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented May 21, 2026

Adds list-resource generation for the following compute resources:

  • google_compute_firewall
  • google_compute_subnetwork
  • google_compute_global_address
`google_compute_firewall`
`google_compute_subnetwork`
`google_compute_global_address`
Local test output
--- PASS: TestAccComputeGlobalAddressListQuery_generated (36.07s)
--- PASS: TestAccComputeSubnetworkListQuery_generated (100.27s)
--- PASS: TestAccComputeFirewallListQuery_generated (204.28s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/compute 205.702s

@BBBmau
Copy link
Copy Markdown
Collaborator Author

BBBmau commented May 21, 2026

@modular-magician reassign-reviewer

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from shuyama1 May 21, 2026 15:56
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bdefb8a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 9 files changed, 943 insertions(+)
google-beta provider View Diff 9 files changed, 943 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
1455 1359 93 3
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeFirewallListQuery_generated
  • TestAccComputeGlobalAddressListQuery_generated
  • TestAccComputeSubnetworkListQuery_generated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeFirewallListQuery_generated
✅ Log TestAccComputeGlobalAddressListQuery_generated
✅ Log TestAccComputeSubnetworkListQuery_generated

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau, @shuyama1 VCR tests complete for bdefb8a!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants