Skip to content

Added support for additional values KCP_VPA in google_container_cluster.logging_config#17670

Open
helenhelen237 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
helenhelen237:kcp-vpa
Open

Added support for additional values KCP_VPA in google_container_cluster.logging_config#17670
helenhelen237 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
helenhelen237:kcp-vpa

Conversation

@helenhelen237
Copy link
Copy Markdown

@helenhelen237 helenhelen237 commented May 21, 2026

Adds terraform support for new VPA Decision logs.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added additional value `KCP_VPA` for `logging_config.enable_components` field in `google_container_cluster` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 21, 2026
@github-actions github-actions Bot requested a review from trodge May 21, 2026 17:30
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@helenhelen237 helenhelen237 changed the title Added support for additional values KCP_HPA in google_container_cluster.logging_config Added support for additional values KCP_VPA in google_container_cluster.logging_config May 21, 2026
@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 21, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 86c1853:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 5 insertions(+), 5 deletions(-)
google-beta provider View Diff 3 files changed, 5 insertions(+), 5 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
293 275 16 2
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@helenhelen237, @trodge VCR tests complete for 86c1853!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/container

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants