Add support for Spanner CMEK Re-encryption#17671
Conversation
Remove the immutable: true flag from the kmsKeyName
Remove the immutable: true flag from encryptionConfig
Remove the immutable: true flag from kmsKeyNames
Add send_empty_value: true to encryptionConfig
Remove ForceNew to not force creating a new database when the key changes
Add re-encryption tests
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Add MR CMEK Re-encryption tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1b4039c: Diff reportYour PR generated the following diffs in downstream repositories:
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @panerorenn9541, @shuyama1 VCR tests complete for 1b4039c! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2b1bc27: Diff reportYour PR generated the following diffs in downstream repositories:
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @panerorenn9541, @shuyama1 VCR tests complete for 2b1bc27! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dc6b78f: Diff reportYour PR generated the following diffs in downstream repositories:
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @panerorenn9541, @shuyama1 VCR tests complete for dc6b78f! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3214cff: Diff reportYour PR generated the following diffs in downstream repositories:
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @panerorenn9541, @shuyama1 VCR tests complete for 3214cff! |
Replace acctest.Bootstrap with resourcemanager.BootstrapIamMembers and kms.BootstrapKMSKey
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2199b07: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @panerorenn9541, @shuyama1 VCR tests complete for 2199b07! |
|
Sorry, I won't have time to review this PR and I'll be out for a week. Assigning a new reviewer. @modular-magician reassign-reviewer |
Support Spanner CMEK Re-encryption
Allow going from CMEK to GMEK, GMEK to CMEK, and CMEK to CMEK
Release Note Template for Downstream PRs (will be copied)