iam_binding: set ResourceIdentity when members are nil#17672
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1799859: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
ResourceIdentity was only being set when matching binding was found, leaving the case of noMembers not covered resulting in missing identity error in VCR. This resolves the failing test we see currently:
follow-up to #17587
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.