Skip to content

compute: extract populateComputeInstanceResourceData from resourceComputeInstanceRead#17674

Draft
tavasyag wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
tavasyag:tavasyag/compute_instace_read_refactor
Draft

compute: extract populateComputeInstanceResourceData from resourceComputeInstanceRead#17674
tavasyag wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
tavasyag:tavasyag/compute_instace_read_refactor

Conversation

@tavasyag
Copy link
Copy Markdown
Contributor

@tavasyag tavasyag commented May 21, 2026

Adds populateComputeInstanceResource() helper which extracts field settings logic from Read

This is primarily for list implementation to be able to use helper

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 721277f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 37 insertions(+), 31 deletions(-)
google-beta provider View Diff 1 file changed, 56 insertions(+), 47 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1456 1359 93 4
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@tavasyag VCR tests complete for 721277f!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 132dc35:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 40 insertions(+), 31 deletions(-)
google-beta provider View Diff 1 file changed, 61 insertions(+), 47 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1456 1359 93 4
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@tavasyag VCR tests complete for 132dc35!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants