Skip to content

Added blank imports to non-service handwritten files that expect certain resources to be registered#17675

Open
melinath wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
melinath:blank-service-imports
Open

Added blank imports to non-service handwritten files that expect certain resources to be registered#17675
melinath wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
melinath:blank-service-imports

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented May 21, 2026

This is a follow-up to #17646; apparently I should've modified a few more files!

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 21, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1885afb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 24 files changed, 33 insertions(+)
google-beta provider View Diff 24 files changed, 33 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6459 5783 659 17
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeAutoscaler_autoscalerBasicExample
  • TestAccComputeAutoscaler_autoscalerSingleInstanceExample
  • TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccIapWebTypeAppEngineIamMemberGenerated
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamBinding_noMembers
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccSourceRepoRepositoryIamMemberGenerated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
✅ Log TestAccDataformConfig_update
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccIapWebTypeAppEngineIamMemberGenerated
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccProjectIamBinding_noMembers
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccSourceRepoRepositoryIamMemberGenerated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for 1885afb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants