Add performance_capture_config to google_sql_database_instance.#17676
Open
sids-agravat wants to merge 2 commits into
Open
Add performance_capture_config to google_sql_database_instance.#17676sids-agravat wants to merge 2 commits into
performance_capture_config to google_sql_database_instance.#17676sids-agravat wants to merge 2 commits into
Conversation
This change introduces the `performance_capture_config` block within the `settings` of a SQL database instance. It includes fields such as `enabled`, `probing_interval_seconds`, `probe_threshold`, `running_threads_threshold`, `seconds_behind_source_threshold`, and `transaction_duration_threshold`. A new acceptance test has been added to verify the functionality, and the documentation has been updated to reflect the new configuration options.
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
…nstance_test.go.tmpl` was renamed in GoogleCloudPlatform#17561 Reverting the changes to support the template tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces the
performance_capture_configblock within thesettingsof a SQL database instance. It includes fields such asenabled,probing_interval_seconds,probe_threshold,running_threads_threshold,seconds_behind_source_threshold, andtransaction_duration_threshold. A new acceptance test has been added to verify the functionality, and the documentation has been updated to reflect the new configuration options.Currently, this is a phased release gating these fields exclusively to the
google-betaprovider to satisfy launch blocking requirements.Testing: b/474020862#comment3
Public doc: https://docs.cloud.google.com/sql/docs/mysql/performance-capture
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.