Fix: Include connection_limit in compute_service_attachment hash

[haixin-huang]

Description

This PR fixes a bug in the google_compute_service_attachment resource where modifications to the connection_limit field within the consumer_accept_lists block would not trigger a Terraform update.

The root cause was that the internal hash function computeServiceAttachmentConsumerAcceptListsHash only incorporated project_id_or_num and network_url. Because consumer_accept_lists is a Set, Terraform uses this hash to identify if an entry has changed. By omitting the connection_limit, Terraform would incorrectly conclude "No changes" when only that field was modified.

This change adds connection_limit to the hashing buffer in the Magic Modules template. An automated acceptance test has been added to verify that limit updates are now correctly detected and applied in-place via a PATCH request.

Fixes: hashicorp/terraform-provider-google#27513

---

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue where updating `connection_limit` in the `consumer_accept_lists` block of `google_compute_service_attachment` would not trigger a resource update.

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[shuyama1]

Sorry, I won't have time to review this PR today and will be OOO for a week. Rotating a new reviewer

@modular-magician reassign-reviewer

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 733a059:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	2 files changed, 104 insertions(+)
google-beta provider	View Diff	2 files changed, 104 insertions(+)
terraform-google-conversion	View Diff	3 files changed, 19 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1458	1364	93	1

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeServiceAttachment_connectionLimitUpdate

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeServiceAttachment_connectionLimitUpdate

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@haixin-huang, @slevenick VCR tests complete for 733a059!