Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion run/idp-sql/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ pg8000==1.31.5
gunicorn==23.0.0
firebase-admin==7.0.0
structlog==25.1.0
urllib3<2.0.0 #https://stackoverflow.com/questions/76175361/firebase-authentication-httpresponse-object-has-no-attribute-strict-status
urllib3<2.7.1 #https://stackoverflow.com/questions/76175361/firebase-authentication-httpresponse-object-has-no-attribute-strict-status

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

To properly address the security vulnerability (CVE-2025-66418), the minimum version of urllib3 should be set to 2.6.0 or higher, as versions prior to 2.6.0 are vulnerable. Specifying only urllib3<2.7.1 allows package managers to resolve to older, vulnerable versions (including 1.x or <2.6.0). Additionally, since this upgrade allows urllib3 v2.x, the comment referencing the strict attribute error on StackOverflow is no longer applicable and should be removed to avoid confusion.

urllib3>=2.6.0,<2.7.1