Skip to content

Class1 newbranch#5

Open
GormanGit wants to merge 10 commits intogh-pagesfrom
class1-newbranch
Open

Class1 newbranch#5
GormanGit wants to merge 10 commits intogh-pagesfrom
class1-newbranch

Conversation

@GormanGit
Copy link
Copy Markdown
Owner

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

Copy link
Copy Markdown

@reneemeyer reneemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataTypes - nice job you need a few tweaks to your code. Also, in the future- a pull request should only have one assignment on it (every assignment gets it's own branch off of gh-pages)

Comment thread 01week/datatypes.js Outdated
function numStr(){
var number = 27;
var a = number.toString();
return a + a
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the indentation on line 38

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also turn any number into a string, not just the number 27

Comment thread 01week/datatypes.js Outdated

function strNum(){
var str = "27";
var a = parseInt(str);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should turn any string into a number, not just the string '27'

Comment thread 01week/datatypes.js Outdated
var d = 27;
var e = Math.sqrt(-1);
var f = "Im having Fun";
return [typeof a, b, c, d, e, typeof f]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should show the typeof of any argument that the function accepts. Don't hardcode variables

Comment thread 01week/datatypes.js
const adding = (a, b) =>{
// a = 7;
// b = 7;
return a + b
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, model all of your functions like this

Comment thread 01week/datatypes.js Outdated
var happiness = function(){
var pizza = true;
var beer = true;
if(pizza && beer === true){
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function hard codes two variables and if pizza evaluates to true and if beer is equal to the boolean true, it runs. I need a function to take into arguments and runs if they both evaluate to true.

Comment thread 01week/datatypes.js Outdated
//call the function


function kindaHappiness(){
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on the happiness() function and apply.

Comment thread 01week/datatypes.js Outdated


function epicSadness(){
var pizza = 1;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on the happiness() function and apply.

Copy link
Copy Markdown

@reneemeyer reneemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jon, you're still off on the last three problems and your program construction. Go ahead and merge and we'll review in class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants