Migrate BytecodeRemappingTest to using ASM#1980
Merged
Conversation
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate BytecodeRemappingTest to use ASM
Migrate BytecodeRemappingTest to using ASM
Mar 17, 2026
…into copilot/migrate-bytecode-remapping-test # Conflicts: # src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/BytecodeRemappingTest.kt
Goooler
force-pushed
the
copilot/migrate-bytecode-remapping-test
branch
from
c649bc0 to
c2d606e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BytecodeRemappingTestusedjava.lang.classfile(Java 24+ API) for parsing remapped class bytes, making the tests fail to compile on JDK < 24. Replaces all usages with ASM (org.vafer.jdeb.shaded.objectweb.asm), which is already on the classpath viajdependency.Changes:
java.lang.classfile.*imports; adds ASM visitor imports (ClassReader,ClassVisitor,FieldVisitor,MethodVisitor,AnnotationVisitor,Label,Opcodes)ClassBytecodeInfo/MethodBytecodeInfodata classes to hold visitor-collected resultsByteArray.classInfo()private extension that drives aClassReader.acceptpass to collect annotations, field descriptors, method descriptors, signatures, local variable descriptors, LDC string constants, CHECKCAST targets, and invoke ownersClassReader; everything else viaclassInfo()