Replace orientation API calls with sensor calculated orientation #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current APIs we use are deprecated/always return 0 since the orientation is fixed for main activity. The rationale behind using accelerometer to reliably calculate orientation is that gravity constantly has small impacts on the accelerometer causing it to continuously generate new values on a real device on start
MHShetty
force-pushed
the
orientation_fix
branch
from
9e852a3 to
1fbe47d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current APIs we use are deprecated/always return 0 since the orientation is fixed for main activity. The rationale behind using accelerometer to reliably calculate orientation is that gravity constantly has small impacts on the accelerometer causing it to continuously generate new values on a real device.
Indirectly fixes the issue described in #534 by only relying on sensor data to calculate orientation