Skip to content

Gracefully fail startup when only CPU Vulkan adapters are available #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShivangSingh68 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

Gracefully fail startup when only CPU Vulkan adapters are available #3743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions node-graph/libraries/wgpu-executor/src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ impl ContextBuilder {
};
instance.request_adapter(&request_adapter_options).await.ok()
}
fn is_supported_adapter(adapter: &Adapter) -> bool {
let info = adapter.get_info();

//Reject CPU-based adapters (e.g. llvmpipe / software Vulkan)
if info.device_type == wgpu::DeviceType::Cpu {
return false;
}
true
}

async fn request_device(&self, adapter: &Adapter) -> Option<(Device, Queue)> {
let device_descriptor = wgpu::DeviceDescriptor {
label: None,
Expand Down Expand Up @@ -111,6 +121,11 @@ impl ContextBuilder {

let adapter = if let Some(adapter) = selected_adapter { adapter } else { self.request_adapter(&instance).await? };

//Fail early if the selected adapter is not supported
if !Self::is_supported_adapter(&adapter) {
return None;
}

let (device, queue) = self.request_device(&adapter).await?;
Some(Context {
device: Arc::new(device),
Expand Down