Skip to content

Fix the Auto-Tangents node for linear polylines, and track colinear handles in manipulator data#3972

Merged
Keavon merged 2 commits intomasterfrom
fix-auto-tangents
Mar 29, 2026
Merged

Fix the Auto-Tangents node for linear polylines, and track colinear handles in manipulator data#3972
Keavon merged 2 commits intomasterfrom
fix-auto-tangents

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Mar 29, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the auto_tangents function in vector_nodes.rs to improve clarity and handle path endpoints more effectively. Key changes include renaming variables for better readability, implementing zero-length cubic handles for open path endpoints, and adding logic to track and mark auto-tangented points as colinear. A review comment identifies redundant logic in the segment index calculation for colinear manipulators, noting that endpoint checks for open paths are unnecessary due to prior filtering.

@Keavon Keavon merged commit e2a1423 into master Mar 29, 2026
10 of 11 checks passed
@Keavon Keavon deleted the fix-auto-tangents branch March 29, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant