Fix the Auto-Tangents node for linear polylines, and track colinear handles in manipulator data#3972
Merged
Fix the Auto-Tangents node for linear polylines, and track colinear handles in manipulator data#3972
Conversation
…andles in manipulator data
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the auto_tangents function in vector_nodes.rs to improve clarity and handle path endpoints more effectively. Key changes include renaming variables for better readability, implementing zero-length cubic handles for open path endpoints, and adding logic to track and mark auto-tangented points as colinear. A review comment identifies redundant logic in the segment index calculation for colinear manipulators, noting that endpoint checks for open paths are unnecessary due to prior filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.