Merged
Conversation
3gf8jv4dv
reviewed
Jan 24, 2026
Contributor
3gf8jv4dv
left a comment
3gf8jv4dv
left a comment
There was a problem hiding this comment.
一些分类为「Configuration」的光影包搜不到。例如 Chocapic13' High Performance shaders。
具体症状是，CF 页面可以找到，但 HMCL 内找不到。
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds CurseForge shader pack download support to HMCL, complementing the existing Modrinth shader pack downloads. Previously, the shader pack download page only used Modrinth as a source; now it also supports CurseForge.
Changes:
- Added
SECTION_SHADERconstant (6552) andSHADERSrepository instance inCurseForgeRemoteModRepository - Wired CurseForge shaders into the
ofShaderPackfactory method inHMCLLocalizedDownloadListPage - Added shader category translations (Realistic, Fantasy, Vanilla) in English, Simplified Chinese, and Traditional Chinese locale files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CurseForgeRemoteModRepository.java |
Added SECTION_SHADER constant and SHADERS static repository instance |
HMCLLocalizedDownloadListPage.java |
Changed ofShaderPack to pass CurseForgeRemoteModRepository.SHADERS instead of null |
I18N.properties |
Added English translations for shader categories 6553-6555 |
I18N_zh_CN.properties |
Added Simplified Chinese translations for shader categories |
I18N_zh.properties |
Added Traditional Chinese translations for shader categories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCLCore/src/main/java/org/jackhuang/hmcl/mod/curse/CurseForgeRemoteModRepository.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Glavo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.