修复了自定义颜色面板打开时没有同步启动器主题颜色，间接修复了bug#5657#5777
Closed
pipixiaa22 wants to merge 1 commit intoHMCL-dev:mainfrom
Closed
Conversation
Contributor
|
哥们 issue id 标错了吧 |
Author
|
是 5767 标错了 |
Contributor
|
那重了啊 |
Contributor
Author
|
@WhatDamon 是的，以你的为准吧，这个修复解决了两个 bug |
Contributor
Author
|
@WhatDamon 好的，我是第一次提交pr ，不懂这些，抱歉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复了 bug#5657
JFXCustomColorPickerDialog 的 setCurrentColor 方法仅仅是设置了内部的 currentColorProperty 属性，但没有将这个颜色应用到颜色选择器 ( curvedColorPicker ) 的 UI 上。所以直接显式调用 curvedColorPicker.setColor(currentColor)即可。
这样下次打开的时候就是和启动同样的颜色，只有当自定义颜色和主题颜色不同的时候，关闭会进行修改