Merged
Conversation
Glavo
reviewed
Mar 15, 2026
| launch.advice.java.auto=当前选择的 Java 版本不满足游戏要求。\n点击“是”即可由 HMCL 来自动选取合适的 Java 版本。\n或者你可以在“(全局/实例特定) 游戏设置 → 游戏 Java”中选择一个合适的 Java 版本。 | ||
| launch.advice.java.modded_java_7=Minecraft 1.7.2 及更低版本需要 Java 7 及更低版本。 | ||
| launch.advice.cleanroom=Cleanroom 只能在 Java 21 或更高版本上运行。请使用 Java 21 或最新版本。 | ||
| launch.advice.cleanroom.newer=Cleanroom 只能在 Java 25 或更高版本上运行。请使用 Java 25 或最新版本。 |
Member
There was a problem hiding this comment.
这几句描述就是错的，这里不应该复制上面的描述，因为 Cleanroom 可以在 Java 21 或更高版本上运行。
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Cleanroom mod's Java version selection logic to dynamically determine the required Java version based on the Cleanroom version, fixing a bug where Cleanroom 0.5.0-alpha wasn't automatically selecting Java 25.
Changes:
- Renamed
CLEANROOM_JAVA_21constraint toCLEANROOMwith dynamic Java version range based on Cleanroom version (≥0.5.0 requires Java 25, older requires Java 21) - Added
GameJavaVersion.getCleanroomJavaVersion()to map Cleanroom versions to required Java versions - Updated i18n strings to include dynamic Java version and Cleanroom version in advice messages
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| GameJavaVersion.java | Added getCleanroomJavaVersion() mapping Cleanroom version to Java version |
| JavaVersionConstraint.java | Renamed CLEANROOM_JAVA_21 to CLEANROOM, added dynamic getJavaVersionRange override, updated method signatures to pass LibraryAnalyzer |
| LauncherHelper.java | Updated all references from CLEANROOM_JAVA_21 to CLEANROOM, added Cleanroom-specific Java version resolution in launch checks |
| JavaManager.java | Updated checkJava call to pass analyzer |
| I18N*.properties | Updated cleanroom advice strings to include version parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| public static GameJavaVersion getCleanroomJavaVersion(String cleanroomVersion) { | ||
| VersionNumber versionNumber = VersionNumber.asVersion(StringUtils.removeSuffix(cleanroomVersion, "-alpha")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resoloves #5780