Skip to content

更新 JFXProgressBar 至 Material Design 3 设计#5792

Closed
Glavo wants to merge 6 commits intoHMCL-dev:mainfrom
Glavo:progress
Closed

更新 JFXProgressBar 至 Material Design 3 设计#5792
Glavo wants to merge 6 commits intoHMCL-dev:mainfrom
Glavo:progress

Conversation

@Glavo
Copy link
Member

@Glavo Glavo commented Mar 15, 2026

image

由 GPT-5.4 完成。

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

此 PR 将 JFXProgressBar 的皮肤与样式更新为更贴近 Material Design 3 的表现(4px 高度、圆角胶囊轨道、分段式 indeterminate 动画),并移除不再使用的 secondary progress 能力,同时补充对应的 JavaFX 皮肤布局测试。

Changes:

  • 重写 JFXProgressBarSkin:改为 track/active/stop 四个 Region 组合,并用 Timeline 驱动 indeterminate 分段动画
  • 更新 root.css:为 .jfx-progress-bar 固定高度 4px,并调整相关选择器与圆角样式
  • 删除 JFXProgressBarsecondaryProgress API,并在 TaskListPane 调整进度条布局边距;新增皮肤布局单测覆盖关键几何行为

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
HMCL/src/test/java/com/jfoenix/skins/JFXProgressBarSkinTest.java 新增针对 determinate/indeterminate 布局几何的 JavaFX 单测
HMCL/src/main/resources/assets/css/root.css 按 MD3 调整 .jfx-progress-bar 高度与指示器/轨道样式选择器
HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/TaskListPane.java 微调任务列表中进度条的上边距以匹配新高度/视觉对齐
HMCL/src/main/java/com/jfoenix/skins/JFXProgressBarSkin.java 重构进度条皮肤与 indeterminate 动画实现以符合新设计
HMCL/src/main/java/com/jfoenix/controls/JFXProgressBar.java 移除 secondaryProgress 属性与相关方法(代码库内无引用)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +5
package com.jfoenix.skins;

import com.jfoenix.controls.JFXProgressBar;
import javafx.application.Platform;
import javafx.scene.Node;
@Glavo Glavo closed this Mar 16, 2026
@Glavo Glavo deleted the progress branch March 16, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants