修复 Curse 整合包更新后未移除旧的模组#6185
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates CurseInstallTask.java to read the previous manifest from manifest.json if it exists, falling back to the configuration manifest. This ensures that resolved file names are used when removing old mods during an update, preventing issues where file names are missing in the raw CurseForge manifest. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Glavo
left a comment
Glavo
left a comment
There was a problem hiding this comment.
本审查建议由 GPT-5 生成
已将具体审查建议标注在对应代码行。
| } catch (IOException | JsonParseException ignored) { | ||
| } | ||
| } | ||
| for (CurseManifestFile oldCurseManifestFile : oldFiles) { |
There was a problem hiding this comment.
本审查建议由 GPT-5 生成
[P2] 这段删除逻辑会在 ModpackInstallTask 已经解包当前整合包 overrides 之后执行。如果新版整合包把某个旧 Curse manifest mod 改为放在 overrides/mods/<same fileName> 中，ModpackInstallTask 会先写入这个新版 override 文件，随后这里因为该旧 projectID/fileID 不在新版 manifest.files() 中而把同一路径删掉。结果是新版整合包明确包含的 override mod 在更新后丢失，仍可能导致缺 mod 或启动失败。修复时需要避免删除当前包 overrides 中已经提供的 mods/... 路径，或调整删除与解包顺序。
2 participants
Fix #4315