Skip to content

Perf: Set fixed cell size for versions list #6186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Glavo merged 1 commit into from
Jun 16, 2026
+3 −0
Merged

Perf: Set fixed cell size for versions list #6186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/download/VersionsPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,9 @@ private static final class VersionsPageSkin extends SkinBase<VersionsPage> {
{
list = new JFXListView<>();
list.getStyleClass().add("jfx-list-view-float");

list.setFixedCellSize(65);

@gemini-code-assist gemini-code-assist Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Setting a hardcoded fixed cell size of 65 is very tight and risks clipping the cell content.

The cell layout (RemoteVersionListCell) has a top and bottom margin of 10 each (totaling 20 pixels of vertical margin). This leaves only 45 pixels of vertical space for the cell content. Within this space, the cell renders a TwoLineListItem which contains a title, potentially tags, and a subtitle.

If the user has a slightly larger system font, or on operating systems with different default font metrics (such as some Linux distributions or when using Chinese system fonts), the combined height of these two lines can easily exceed 45 pixels, leading to vertical clipping or text truncation.

Using a slightly larger and safer height (e.g., 72 pixels) provides enough headroom to prevent layout breakage while retaining the performance benefits of setFixedCellSize.

Suggested change
list.setFixedCellSize(65);
// Use 72 to provide headroom for two-line items with tags and prevent clipping
list.setFixedCellSize(72);


VBox.setVgrow(list, Priority.ALWAYS);

control.versions.addListener((InvalidationListener) o -> updateList());
Expand Down