Yana P #2
Open
Yana P #2
+108
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
mo92othman
approved these changes
Feb 1, 2026
mo92othman
left a comment
mo92othman
left a comment
There was a problem hiding this comment.
Hi @YanaP1312, well done! 👍
Good job refactoring the code in Task 4. You show a good understanding of the DRY principle. Good luck in the next modules!
| const bookName = "The fundamentals of JavaScript".toLowerCase(); | ||
| const pureString = searchString.trim().toLowerCase(); | ||
|
|
||
| if(!pureString) return false; |
Comment on lines
+9
to
+11
| const first = Number(date.substring(0, firstDash)); | ||
| const second = Number(date.substring(firstDash + 1, lastDash)); | ||
| const third = Number(date.substring(lastDash + 1)); |
There was a problem hiding this comment.
Nice, this works correctly 👍
You could also use split("-") here, which would make the code easier to read and maintain.
Minor note: more descriptive variable names (like day or month) can improve readability, but this is also fine at this stage.
Comment on lines
+1
to
+11
| export const convertHoursToMinutes = hours => hours * 60; | ||
|
|
||
| export const convertMinutesToHours = minutes => minutes / 60; | ||
|
|
||
| export const convertDaysToHours = days => days * 24; | ||
|
|
||
| export const convertHoursToDays = hours => hours / 24; | ||
|
|
||
| export const convertMinutesToSeconds = minutes => minutes * 60; | ||
|
|
||
| export const convertSecondsToMinutes = seconds => seconds / 60; No newline at end of file |
Comment on lines
+2
to
+3
| const part_1 = weatherReport(city, celsius); | ||
| const part_2 = windChillCalculation(city, celsius, speed); |
There was a problem hiding this comment.
Minor suggestions: use more descriptive variable names instead of part_1 and part_2 .
mo92othman
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done tasks for week-3