ci: test against Node 18, 20, and 22 (full engines range)#66
Open
dmchaledev wants to merge 1 commit into
Open
Conversation
The package declares engines >= 18 but CI only validated Node 20. Node 18 is still in maintenance LTS and Node 22 is the current LTS, so regressions on those versions would have gone undetected. https://claude.ai/code/session_01LCsREUiKF2K3rvpJyih1h4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
package.jsondeclares"engines": { "node": ">=18.0.0" }, but CI only ran against Node 20. That means:A regression on either version would ship to npm users undetected.
Fix
Add a
strategy.matrixto the CI job so it runs on Node 18, 20, and 22 in parallel. No production code changes — purely additive CI improvement.Test plan
Node 18,Node 20,Node 22) passtypecheck,test, andbuildci.ymlhttps://claude.ai/code/session_01LCsREUiKF2K3rvpJyih1h4
Generated by Claude Code