Set base_path to directory of bundle file#90
Open
mildsunrise wants to merge 2 commits intoHearthSim:masterfrom
Open
Set base_path to directory of bundle file#90mildsunrise wants to merge 2 commits intoHearthSim:masterfrom
mildsunrise wants to merge 2 commits intoHearthSim:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(See #74) Currently, something like
will fail with
KeyError: "No such asset: 'sharedassets0.resource'", whilecd extracted unityextract --all data.unity3dwill work. This patch sets
base_pathto the same directory where the loaded Unity3D file is (by default), and mentions that Unity3D files can reference external files (for people who didn't know, like me).