Fix installation documentation and configuration#220
Fix installation documentation and configuration#220isalyne34 wants to merge 2 commits intoHugoGresse:mainfrom
Conversation
fix: update readme fix : readme
b766623 to
c8fad34
Compare
There was a problem hiding this comment.
Pull request overview
Improves first-time setup by updating installation documentation and adjusting Firebase Hosting configuration for multi-site deployments and ServiceApi swagger hosting.
Changes:
- Restructures
README.mdsetup steps (Firebase requirements, CLI workflow, local run instructions). - Updates
firebase.jsonhosting entries (switch tositeand correct ServiceApi public directory). - Adds
serviceapi-swagger/.emptyto ensure the swagger directory exists in the repo.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
serviceapi-swagger/.empty |
Ensures serviceapi-swagger directory is present for hosting/public path. |
functions/package-lock.json |
Adds license metadata for a couple of dependencies in the lockfile. |
firebase.json |
Updates hosting configuration (site ids + ServiceApi swagger public dir). |
README.md |
Updates installation/setup instructions for Firebase, hosting, and local dev. |
Files not reviewed (1)
- functions/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
firebase.json
Outdated
| "site": "conferencecenterr2", | ||
| "public": "dist", | ||
| "ignore": ["firebase.json", "**/.*", "**/node_modules/**"], |
There was a problem hiding this comment.
The hosting config hard-codes a specific Hosting site id ("conferencecenterr2"). Since .firebaserc is gitignored and the repo includes .firebaserc.example targets, committing environment-specific site ids will likely break deploys for other developers/projects. Consider reverting this entry back to using target and rely on firebase target:apply, or make the committed value a generic/default site id that matches the documented setup.
There was a problem hiding this comment.
hmm interessant !
je pense aussi qu'il faut que on trouve une autre solution
There was a problem hiding this comment.
J'ai mis a jour le .firebaserc.example et modifié le firebase.json afin que ce dernier prenne en compte les valeurs présentes dans .firebasrc, les valeurs ne sont ainsi plus hard-codées dans le firebase.json
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- functions/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- functions/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix readme fix readme
0ee5933 to
a330dda
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 6 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- functions/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "projects": { | ||
| "default": "conferencecenterr" | ||
| "default": "openplanner" | ||
| }, | ||
| "targets": { | ||
| "conferencecenterr": { | ||
| "openplanner": { | ||
| "hosting": { |
There was a problem hiding this comment.
In .firebaserc, projects.default is expected to be a Firebase project ID or a locally-defined alias. Using openplanner as the example value can be confused with the Web App name from the README. Consider changing this to an explicit placeholder like your-firebase-project-id (and similarly for the targets top-level key) to reduce setup mistakes.
Summary
Improves the installation process to make first-time setup smoother by clarifying steps and fixing configuration issues.
Changes
README updates:
Configuration fixes:
firebase.jsonto use site instead of target for hosting deploymentapi-swaggertoserviceapi-swaggerserviceapi-swaggerto ensure directory exists