Skip to content

one parenthesis, 2 hours of my time #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oganigl wants to merge 4 commits into from
+5 −3
Closed

one parenthesis, 2 hours of my time #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
360870e
one parenthesis, 2 hours of my time
oganigl Jun 12, 2026
ba85d25
come on
oganigl Jun 12, 2026
c1cabec
added one empty line, useful indentation thank you pre-commit
oganigl Jun 12, 2026
058e5eb
change test
oganigl Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changesets/fix_linear_sensor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
release: patch
summary: Is just one parenthesis come on
2 changes: 1 addition & 1 deletion Inc/ST-LIB_LOW/Sensors/LinearSensor/LinearSensor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ template <class Type>
requires std::is_integral_v<Type> || std::is_floating_point_v<Type>
Type LinearSensor<Type>::compute_value_from_voltage(float voltage) const {
const Type sensor_voltage = static_cast<Type>(voltage);
return slope * sensor_voltage + offset;
return slope * (sensor_voltage + offset);
}

template <class Type>
Expand Down
4 changes: 2 additions & 2 deletions Tests/adc_sensor_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ TEST_F(ADCSensorTest, LinearSensorUsesNormalizedADCVoltageForItsTransferFunction
LinearSensor<float> sensor(SingleADCInit::instances[0], 2.0f, -1.0f, output, 5.0f);
sensor.read();

EXPECT_NEAR(output, 2.0f * ((512.0f / 1023.0f) * 5.0f) - 1.0f, 0.001f);
EXPECT_NEAR(output, 2.0f * (((512.0f / 1023.0f) * 5.0f) - 1.0f), 0.001f);
}

TEST_F(ADCSensorTest, FilteredLinearSensorReusesTheSameADCConversionPath) {
Expand All @@ -151,7 +151,7 @@ TEST_F(ADCSensorTest, FilteredLinearSensorReusesTheSameADCConversionPath) {
sensor.read();
sensor.read();

EXPECT_NEAR(output, 2.0f * ((2048.0f / 4095.0f) * 3.3f) + 1.0f, 0.001f);
EXPECT_NEAR(output, 2.0f * (((2048.0f / 4095.0f) * 3.3f) + 1.0f), 0.001f);
}

TEST_F(ADCSensorTest, LookupSensorMapsEquivalentNormalizedReadingsAcrossResolutions) {
Expand Down
Loading