Skip to content

fix: better jsDoc on omitting the publicApiKey from toggle option#124

Merged
jaredwray merged 1 commit intomainfrom
fix-better-jsDoc-on-omitting-the-publicApiKey-from-toggle-option
Mar 4, 2026
Merged

fix: better jsDoc on omitting the publicApiKey from toggle option#124
jaredwray merged 1 commit intomainfrom
fix-better-jsDoc-on-omitting-the-publicApiKey-from-toggle-option

Conversation

@jaredwray
Copy link
Contributor

@jaredwray jaredwray commented Mar 4, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix: better jsDoc on omitting the publicApiKey from toggle option

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the JSDoc comments within the HyphenOptions interface. The updates clarify that certain API key properties are intentionally excluded from the nested configuration objects for Toggle, NetInfo, and Link services, as these keys are managed at the top-level HyphenOptions object. This enhancement improves the clarity and accuracy of the API documentation for developers.

Highlights

  • Documentation Improvement: Updated JSDoc comments for HyphenOptions to explicitly state that publicApiKey and apiKey are omitted from nested service options (Toggle, NetInfo, Link) because they are provided at the top level.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/hyphen.ts
    • Added JSDoc comments to toggle, netInfo, and link properties within HyphenOptions to indicate that publicApiKey or apiKey are excluded from their respective nested options.
Activity
  • No specific activity or comments have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jaredwray jaredwray merged commit eba8cc8 into main Mar 4, 2026
7 checks passed
@jaredwray jaredwray deleted the fix-better-jsDoc-on-omitting-the-publicApiKey-from-toggle-option branch March 4, 2026 19:27
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request enhances the JSDoc comments for toggle, netInfo, and link options within HyphenOptions, clarifying why publicApiKey and apiKey are omitted from nested option types as they are provided at the top level. A security review found no vulnerabilities, as the changes are limited to documentation updates and do not affect executable logic or introduce security risks. This improves the clarity and understanding of the API's configuration structure.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a313d9c) to head (db3b97d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          477       477           
  Branches        99        95    -4     
=========================================
  Hits           477       477           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant