Merged
Conversation
- Update pyproject.toml requires-python from >=3.6 to >=3.8 - Update setup.cfg classifiers to remove Python 3.6 and 3.7 support - Add support for Python 3.8, 3.9, 3.10, 3.11, and 3.12 - Update Dockerfile.dev to use Python 3.8 base image This change is necessary because the code uses importlib.metadata which was introduced in Python 3.8, making the previous >=3.6 requirement incorrect and causing import errors on older versions.
- Remove legacy setup.py and setup.cfg files - Update pyproject.toml to configure proper package discovery - Exclude node_modules, tests, examples, and venv from package discovery - Fix Docker build error caused by multiple top-level packages
- Add unit-tests job to build-and-test.yaml for Python 3.8 - Keep existing vulnerability-scan job using shared action - Add dev dependencies (pytest, pytest-cov, unittest-xml-reporting) to pyproject.toml - Remove setuptools from runtime dependencies (only needed for build) - Tested locally: 287 tests pass successfully
- Change from setuptools == 68.2.2 to setuptools < 81 - Allows more flexibility while maintaining compatibility - Keeps setuptools in build-system where it's needed for setuptools.build_meta
- Add unit-tests job that runs before build-and-publish - Tests run on Ubuntu with Python 3.8 (same as build-and-test.yaml) - Add needs: unit-tests dependency to ensure tests pass before publishing - Prevents publishing broken code to PyPi - Tested locally: 287 tests pass successfully
Ian-Nara
approved these changes
Oct 14, 2025
cYKatherine
approved these changes
Oct 14, 2025
cYKatherine
reviewed
Oct 14, 2025
| unit-tests: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: |
Contributor
There was a problem hiding this comment.
why do we use matrix here 🤔
Contributor
Author
There was a problem hiding this comment.
so we could define a range of setups to run unit tests on, e.g. like below i extended to not just run unit tests on py 3.8 but 3.9/3.10/etc add test coverage, like this run:
https://github.com/IABTechLab/uid2-client-python/actions/runs/18513552871
- Test against Python 3.8, 3.9, 3.10, 3.11, 3.12, 3.13 - Ensures compatibility across supported Python versions - Improves test coverage and catches version-specific issues
…aml github action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Python Version & Dependency Updates
2. Modernizing Package Configuration
3. CI and Testing Enhancements