Skip to content

[Fix] 0047059 UI: Use role="navigation" for LegacySlate in MainBar #11014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fhelfer wants to merge 2 commits into
base: release_11
Choose a base branch
from
+7 −3
Open

[Fix] 0047059 UI: Use role="navigation" for LegacySlate in MainBar #11014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b849770
[Fix] 0047059 UI: Use role="navigation" for LegacySlate in MainBar (A…
fhelfer Jan 30, 2026
6c9286c
[Fix] 0047059 UI: Remove comments
fhelfer Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/ILIAS/UI/src/Implementation/Component/MainControls/Renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
use ILIAS\UI\Component\MainControls\Footer;
use ILIAS\UI\Component\MainControls\MainBar;
use ILIAS\UI\Component\MainControls\MetaBar;
use ILIAS\UI\Component\MainControls\Slate\Legacy as LegacySlate;
use ILIAS\UI\Component\MainControls\Slate\Slate;
use ILIAS\UI\Component\Signal;
use ILIAS\UI\Implementation\Component\Button\Bulky as IBulky;
Expand Down Expand Up @@ -166,7 +167,8 @@ function ($id) use ($js, $mb_id, $k, $is_tool): string {
$tpl->parseCurrentBlock();

if ($slate) {
$entry = $entry->withAriaRole(ISlate::MENU);
$aria_role = ($entry instanceof LegacySlate) ? ISlate::NAVIGATION : ISlate::MENU;
$entry = $entry->withAriaRole($aria_role);

$tpl->setCurrentBlock("slate_item");
$tpl->setVariable("SLATE", $default_renderer->render($entry));
Expand Down
4 changes: 3 additions & 1 deletion components/ILIAS/UI/src/Implementation/Component/MainControls/Slate/Slate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ abstract class Slate implements ISlate\Slate

// allowed ARIA roles
public const MENU = 'menu';
public const NAVIGATION = 'navigation';

/**
* @var string[]
*/
protected static array $allowed_aria_roles = array(
self::MENU
self::MENU,
self::NAVIGATION
);

protected string $name;
Expand Down
2 changes: 1 addition & 1 deletion components/ILIAS/UI/tests/Component/MainControls/MainBarTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ public function testRendering(): void
<div class="il-maincontrols-slate disengaged" id="id_10" data-depth-level="1" role="menu">
<div class="il-maincontrols-slate-content" data-replace-marker="content"></div>
</div>
<div class="il-maincontrols-slate disengaged" id="id_13" data-depth-level="1" role="menu">
<div class="il-maincontrols-slate disengaged" id="id_13" data-depth-level="1" role="navigation">
<div class="il-maincontrols-slate-content" data-replace-marker="content">Help</div>
</div>
<div class="il-mainbar-close-slates">
Expand Down