Skip to content

[Fix] 0047062 UI: Canvas height attribute must be numeric (no "px") #11016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fhelfer wants to merge 1 commit into
base: release_11
Choose a base branch
from
+4 −4
Open

[Fix] 0047062 UI: Canvas height attribute must be numeric (no "px") #11016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/ILIAS/UI/src/Implementation/Component/Chart/Bar/Renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ protected function determineHeightForHorizontal(Bar\Bar $component): string
$height = $max_height;
}

return $height . "px";
return (string) (int) $height;
}

protected function determineHeightForVertical(Bar\Bar $component): string
Expand All @@ -149,7 +149,7 @@ protected function determineHeightForVertical(Bar\Bar $component): string
$height = $max_height;
}

return $height . "px";
return (string) (int) $height;
}

protected function getAccessibilityList(
Expand Down
4 changes: 2 additions & 2 deletions components/ILIAS/UI/tests/Component/Chart/Bar/ChartBarTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public function testRenderHorizontal(): void

$expected_html = <<<EOT
<div class="il-chart-bar-horizontal">
<canvas id="id_1" height="150px" aria-label="bar123" role="img"></canvas>
<canvas id="id_1" height="150" aria-label="bar123" role="img"></canvas>
</div>
<div class="sr-only">
<dl>
Expand Down Expand Up @@ -378,7 +378,7 @@ public function testRenderVertical(): void

$expected_html = <<<EOT
<div class="il-chart-bar-vertical">
<canvas id="id_1" height="165px" aria-label="bar123" role="img"></canvas>
<canvas id="id_1" height="165" aria-label="bar123" role="img"></canvas>
</div>
<div class="sr-only">
<dl>
Expand Down