Skip to content

[Fix] 0047063 UI: Rating – aria-label on input instead of label #11018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fhelfer wants to merge 1 commit into
base: release_11
Choose a base branch
from
Open

[Fix] 0047063 UI: Rating – aria-label on input instead of label #11018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/ILIAS/UI/src/templates/default/Input/tpl.rating.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
<!-- END average -->

<!-- BEGIN scaleoption -->
<input aria-describedby="{DESCRIPTION_ID}" type="radio" id="{OPT_ID}" name="{NAME}" value="{OPT_VALUE}" class="il-input-rating-scaleoption" {DISABLED}{SELECTED}/>
<label class="glyphicon-star il-input-rating-star" for="{OPT_ID}" aria-label="{ARIALABEL}"></label>
<input aria-describedby="{DESCRIPTION_ID}" aria-label="{ARIALABEL}" type="radio" id="{OPT_ID}" name="{NAME}" value="{OPT_VALUE}" class="il-input-rating-scaleoption" {DISABLED}{SELECTED}/>
<label class="glyphicon-star il-input-rating-star" for="{OPT_ID}"></label>
<!-- END scaleoption -->
</div>

<!-- BEGIN scaleoption_neutral -->
<div class="il-input-rating__none">
<label for="{NEUTRAL_ID}" aria-label="{NEUTRAL_LABEL}">{NEUTRAL_LABEL}</label>
<label for="{NEUTRAL_ID}">{NEUTRAL_LABEL}</label>
<input aria-describedby="{NEUTRAL_DESCRIPTION_ID}" type="radio" id="{NEUTRAL_ID}" name="{NEUTRAL_NAME}" value="0" {DISABLED}{NEUTRAL_SELECTED}/>
</div>
<!-- END scaleoption_neutral -->
Expand Down
44 changes: 22 additions & 22 deletions components/ILIAS/UI/tests/Component/Input/Field/RatingInputTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,23 +69,23 @@ public function testRatingRenderBasic(): void
<legend class="il-input-rating__text" id="id_1_desc"></legend>
<div class="il-input-rating__stars" role="radiogroup">
<div class="il-input-rating__options">
<input aria-describedby="id_1_desc" type="radio" id="id_1-5" name="name_0" value="5" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-5" aria-label="5stars"></label>
<input aria-describedby="id_1_desc" aria-label="5stars" type="radio" id="id_1-5" name="name_0" value="5" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-5"></label>

<input aria-describedby="id_1_desc" type="radio" id="id_1-4" name="name_0" value="4" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-4" aria-label="4stars"></label>
<input aria-describedby="id_1_desc" aria-label="4stars" type="radio" id="id_1-4" name="name_0" value="4" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-4"></label>

<input aria-describedby="id_1_desc" type="radio" id="id_1-3" name="name_0" value="3" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-3" aria-label="3stars"></label>
<input aria-describedby="id_1_desc" aria-label="3stars" type="radio" id="id_1-3" name="name_0" value="3" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-3"></label>

<input aria-describedby="id_1_desc" type="radio" id="id_1-2" name="name_0" value="2" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-2" aria-label="2stars"></label>
<input aria-describedby="id_1_desc" aria-label="2stars" type="radio" id="id_1-2" name="name_0" value="2" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-2"></label>

<input aria-describedby="id_1_desc" type="radio" id="id_1-1" name="name_0" value="1" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-1" aria-label="1stars"></label>
<input aria-describedby="id_1_desc" aria-label="1stars" type="radio" id="id_1-1" name="name_0" value="1" class="il-input-rating-scaleoption" />
<label class="glyphicon-star il-input-rating-star" for="id_1-1"></label>
</div>
<div class="il-input-rating__none">
<label for="id_1-0" aria-label="reset_stars">reset_stars</label>
<label for="id_1-0">reset_stars</label>
<input aria-describedby="id_1_desc" type="radio" id="id_1-0" name="name_0" value="0" checked="checked"/>
</div>
</div>
Expand Down Expand Up @@ -121,24 +121,24 @@ public function testRatingRenderFull(): void
<div class="il-input-rating__average_value" style="width:60%;"></div>
</div>

<input aria-describedby="id_1_desc" type="radio" id="id_1-5" name="name_0" value="5" class="il-input-rating-scaleoption" disabled="disabled"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-5" aria-label="5stars"></label>
<input aria-describedby="id_1_desc" aria-label="5stars" type="radio" id="id_1-5" name="name_0" value="5" class="il-input-rating-scaleoption" disabled="disabled"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-5"></label>

<input aria-describedby="id_1_desc" type="radio" id="id_1-4" name="name_0" value="4" class="il-input-rating-scaleoption" disabled="disabled" checked="checked"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-4" aria-label="4stars"></label>
<input aria-describedby="id_1_desc" aria-label="4stars" type="radio" id="id_1-4" name="name_0" value="4" class="il-input-rating-scaleoption" disabled="disabled" checked="checked"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-4"></label>

<input aria-describedby="id_1_desc" type="radio" id="id_1-3" name="name_0" value="3" class="il-input-rating-scaleoption" disabled="disabled"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-3" aria-label="3stars"></label>
<input aria-describedby="id_1_desc" aria-label="3stars" type="radio" id="id_1-3" name="name_0" value="3" class="il-input-rating-scaleoption" disabled="disabled"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-3"></label>

<input aria-describedby="id_1_desc" type="radio" id="id_1-2" name="name_0" value="2" class="il-input-rating-scaleoption" disabled="disabled"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-2" aria-label="2stars"></label>
<input aria-describedby="id_1_desc" aria-label="2stars" type="radio" id="id_1-2" name="name_0" value="2" class="il-input-rating-scaleoption" disabled="disabled"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-2"></label>

<input aria-describedby="id_1_desc" type="radio" id="id_1-1" name="name_0" value="1" class="il-input-rating-scaleoption" disabled="disabled"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-1" aria-label="1stars"></label>
<input aria-describedby="id_1_desc" aria-label="1stars" type="radio" id="id_1-1" name="name_0" value="1" class="il-input-rating-scaleoption" disabled="disabled"/>
<label class="glyphicon-star il-input-rating-star" for="id_1-1"></label>
</div>

<div class="il-input-rating__none">
<label for="id_1-0" aria-label="reset_stars">reset_stars</label>
<label for="id_1-0">reset_stars</label>
<input aria-describedby="id_1_desc" type="radio" id="id_1-0" name="name_0" value="0" />
</div>

Expand Down