Skip to content

[Fix] 0047066 UI: Standard filter – add aria-labelledby to region divs #11022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fhelfer wants to merge 1 commit into
base: release_11
Choose a base branch
from
Open

[Fix] 0047066 UI: Standard filter – add aria-labelledby to region divs #11022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/ILIAS/UI/src/templates/default/Input/tpl.standard_filter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
<div class="il-filter-bar-toggle"> {TOGGLE} </div>
</div>
<!-- BEGIN active_inputs_section -->
<div class="il-filter-inputs-active clearfix" id="active_inputs_{ID_FILTER_ACTIVE}" aria-labelledby="opener_{ID_FILTER_ACTIVE}" data-active-inputs-expanded="{ACTIVE_INPUTS_EXPANDED}"><!-- BEGIN active_inputs --> <span id="{ID_INPUT_ACTIVE}"> </span> <!-- END active_inputs --></div>
<div class="il-filter-inputs-active clearfix" id="active_inputs_{ID_FILTER_ACTIVE}" role="region" aria-labelledby="opener_{ID_FILTER_ACTIVE}" data-active-inputs-expanded="{ACTIVE_INPUTS_EXPANDED}"><!-- BEGIN active_inputs --> <span id="{ID_INPUT_ACTIVE}"> </span> <!-- END active_inputs --></div>
<!-- END active_inputs_section -->
<div class="il-filter-input-section row" id="section_inputs_{ID_FILTER}" aria-labelledby="opener_{ID_FILTER}" data-section-inputs-expanded="{SECTION_INPUTS_EXPANDED}">
<div class="il-filter-input-section row" id="section_inputs_{ID_FILTER}" role="region" aria-labelledby="opener_{ID_FILTER}" data-section-inputs-expanded="{SECTION_INPUTS_EXPANDED}">
{INPUTS}
<div class="il-filter-controls"> {APPLY} {RESET} </div>
</div>
Expand Down
16 changes: 8 additions & 8 deletions components/ILIAS/UI/tests/Component/Input/Container/Filter/StandardFilterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,12 @@ public function testRenderActivatedCollapsed(): void
</div>
</div>
</div>
<div class="il-filter-inputs-active clearfix" id="active_inputs_id_1" aria-labelledby="opener_id_1" data-active-inputs-expanded="1">
<div class="il-filter-inputs-active clearfix" id="active_inputs_id_1" role="region" aria-labelledby="opener_id_1" data-active-inputs-expanded="1">
<span id="1"></span>
<span id="2"></span>
<span id="3"></span>
</div>
<div class="il-filter-input-section row" id="section_inputs_id_1" aria-labelledby="opener_id_1" data-section-inputs-expanded="0">
<div class="il-filter-input-section row" id="section_inputs_id_1" role="region" aria-labelledby="opener_id_1" data-section-inputs-expanded="0">
<div class="col-md-6 col-lg-4 il-popover-container">
<div class="input-group">
<label for="id_5" class="input-group-addon leftaddon">Title</label>
Expand Down Expand Up @@ -344,12 +344,12 @@ public function testRenderDeactivatedCollapsed(): void
</div>
</div>
</div>
<div class="il-filter-inputs-active clearfix" id="active_inputs_id_1" aria-labelledby="opener_id_1" data-active-inputs-expanded="1">
<div class="il-filter-inputs-active clearfix" id="active_inputs_id_1" role="region" aria-labelledby="opener_id_1" data-active-inputs-expanded="1">
<span id="1"></span>
<span id="2"></span>
<span id="3"></span>
</div>
<div class="il-filter-input-section row" id="section_inputs_id_1" aria-labelledby="opener_id_1" data-section-inputs-expanded="0">
<div class="il-filter-input-section row" id="section_inputs_id_1" role="region" aria-labelledby="opener_id_1" data-section-inputs-expanded="0">
<div class="col-md-6 col-lg-4 il-popover-container">
<div class="input-group">
<label for="id_5" class="input-group-addon leftaddon">Title</label>
Expand Down Expand Up @@ -482,12 +482,12 @@ public function testRenderActivatedExpanded(): void
</div>
</div>
</div>
<div class="il-filter-inputs-active clearfix" id="active_inputs_id_1" aria-labelledby="opener_id_1" data-active-inputs-expanded="0">
<div class="il-filter-inputs-active clearfix" id="active_inputs_id_1" role="region" aria-labelledby="opener_id_1" data-active-inputs-expanded="0">
<span id="1"></span>
<span id="2"></span>
<span id="3"></span>
</div>
<div class="il-filter-input-section row" id="section_inputs_id_1" aria-labelledby="opener_id_1" data-section-inputs-expanded="1">
<div class="il-filter-input-section row" id="section_inputs_id_1" role="region" aria-labelledby="opener_id_1" data-section-inputs-expanded="1">
<div class="col-md-6 col-lg-4 il-popover-container">
<div class="input-group">
<label for="id_5" class="input-group-addon leftaddon">Title</label>
Expand Down Expand Up @@ -620,12 +620,12 @@ public function testRenderDeactivatedExpanded(): void
</div>
</div>
</div>
<div class="il-filter-inputs-active clearfix" id="active_inputs_id_1" aria-labelledby="opener_id_1" data-active-inputs-expanded="0">
<div class="il-filter-inputs-active clearfix" id="active_inputs_id_1" role="region" aria-labelledby="opener_id_1" data-active-inputs-expanded="0">
<span id="1"></span>
<span id="2"></span>
<span id="3"></span>
</div>
<div class="il-filter-input-section row" id="section_inputs_id_1" aria-labelledby="opener_id_1" data-section-inputs-expanded="1">
<div class="il-filter-input-section row" id="section_inputs_id_1" role="region" aria-labelledby="opener_id_1" data-section-inputs-expanded="1">
<div class="col-md-6 col-lg-4 il-popover-container">
<div class="input-group">
<label for="id_5" class="input-group-addon leftaddon">Title</label>
Expand Down