Allow Dataset Creation API to take Template ID#12405
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
5b23c8f to
ce7a795
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
ce7a795 to
e8f7f1f
Compare
This comment has been minimized.
This comment has been minimized.
|
@stevenwinship to support the SPA, we also need the Get Dataset API to return the template_id, can you add that to this PR? Or would it be better to have a separate issue? |
Update from Steve, this is already in the current PR. thanks! |
e8f7f1f to
665d78c
Compare
This comment has been minimized.
This comment has been minimized.
665d78c to
99a1d0e
Compare
This comment has been minimized.
This comment has been minimized.
99a1d0e to
9de380c
Compare
This comment has been minimized.
This comment has been minimized.
9de380c to
94b1847
Compare
This comment has been minimized.
This comment has been minimized.
94b1847 to
d9e1e4f
Compare
This comment has been minimized.
This comment has been minimized.
d9e1e4f to
aff9aaf
Compare
This comment has been minimized.
This comment has been minimized.
|
@stevenwinship I'm testing the SPA and I realized that with this update, we also need to make sure that if a template_id is passed to the create dataset API, the usageCount for that template needs to be incremented. |
|
@stevenwinship this API also needs to apply terms of use and license values from the template, if they exist. Edit: I think we could send the terms of use and license from the template in the API payload, rather than having that logic happen in the backend. I'm going to look at that more. |
Fixed |
This comment has been minimized.
This comment has been minimized.
940a8d5 to
e67ad74
Compare
Confirmed that we can handle this on the client side, no need to update the API |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it: Users creating Datasets need to be able to set the Template via the Create API
Which issue(s) this PR closes:#12132
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: