Skip to content

Allow Dataset Creation API to take Template ID#12405

Open
stevenwinship wants to merge 3 commits into
developfrom
12132-dataset-creation-with-template
Open

Allow Dataset Creation API to take Template ID#12405
stevenwinship wants to merge 3 commits into
developfrom
12132-dataset-creation-with-template

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

What this PR does / why we need it: Users creating Datasets need to be able to set the Template via the Create API

Which issue(s) this PR closes:#12132

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship self-assigned this May 22, 2026
@github-actions github-actions Bot added FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA SPA.Q4.2025.1 Create/Edit Template Feature Status: Needs Input Applied to issues in need of input from someone currently unavailable Type: Feature a feature request labels May 22, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project May 22, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 22, 2026

Coverage Status

coverage: 25.071% (+0.001%) from 25.07% — 12132-dataset-creation-with-template into develop

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project May 26, 2026
@stevenwinship stevenwinship removed their assignment May 26, 2026
@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch 2 times, most recently from 5b23c8f to ce7a795 Compare May 26, 2026 18:17
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

Test Results

397 tests  ±0   382 ✅ ±0   37m 8s ⏱️ +11s
 53 suites ±0    15 💤 ±0 
 53 files   ±0     0 ❌ ±0 

Results for commit e67ad74. ± Comparison against base commit a3b8fd7.

♻️ This comment has been updated with latest results.

@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch from ce7a795 to e8f7f1f Compare May 26, 2026 21:13
@github-actions

This comment has been minimized.

@ekraffmiller
Copy link
Copy Markdown
Contributor

@stevenwinship to support the SPA, we also need the Get Dataset API to return the template_id, can you add that to this PR? Or would it be better to have a separate issue?

@ekraffmiller
Copy link
Copy Markdown
Contributor

@stevenwinship to support the SPA, we also need the Get Dataset API to return the template_id, can you add that to this PR? Or would it be better to have a separate issue?

Update from Steve, this is already in the current PR. thanks!

@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch from e8f7f1f to 665d78c Compare May 29, 2026 15:50
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch from 665d78c to 99a1d0e Compare June 1, 2026 13:03
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch from 99a1d0e to 9de380c Compare June 1, 2026 14:01
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch from 9de380c to 94b1847 Compare June 1, 2026 20:51
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch from 94b1847 to d9e1e4f Compare June 3, 2026 15:04
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 25 FY26 Sprint 25 (2026-06-03 - 2026-06-17) label Jun 3, 2026
@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch from d9e1e4f to aff9aaf Compare June 4, 2026 18:07
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship added this to the 6.12 milestone Jun 4, 2026
@ekraffmiller
Copy link
Copy Markdown
Contributor

@stevenwinship I'm testing the SPA and I realized that with this update, we also need to make sure that if a template_id is passed to the create dataset API, the usageCount for that template needs to be incremented.

@ekraffmiller
Copy link
Copy Markdown
Contributor

ekraffmiller commented Jun 5, 2026

@stevenwinship this API also needs to apply terms of use and license values from the template, if they exist.

Edit: I think we could send the terms of use and license from the template in the API payload, rather than having that logic happen in the backend. I'm going to look at that more.

@stevenwinship stevenwinship self-assigned this Jun 5, 2026
@stevenwinship stevenwinship moved this from Ready for Review ⏩ to In Progress 💻 in IQSS Dataverse Project Jun 5, 2026
@stevenwinship
Copy link
Copy Markdown
Contributor Author

@stevenwinship I'm testing the SPA and I realized that with this update, we also need to make sure that if a template_id is passed to the create dataset API, the usageCount for that template needs to be incremented.

Fixed

@stevenwinship stevenwinship removed their assignment Jun 5, 2026
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Jun 5, 2026
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship force-pushed the 12132-dataset-creation-with-template branch from 940a8d5 to e67ad74 Compare June 8, 2026 13:30
@ekraffmiller
Copy link
Copy Markdown
Contributor

@stevenwinship this API also needs to apply terms of use and license values from the template, if they exist.

Edit: I think we could send the terms of use and license from the template in the API payload, rather than having that logic happen in the backend. I'm going to look at that more.

Confirmed that we can handle this on the client side, no need to update the API

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 8, 2026

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12132-dataset-creation-with-template
ghcr.io/gdcc/configbaker:12132-dataset-creation-with-template

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) FY26 Sprint 25 FY26 Sprint 25 (2026-06-03 - 2026-06-17) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 10 A percentage of a sprint. 7 hours. SPA.Q4.2025.1 Create/Edit Template Feature SPA These changes are required for the Dataverse SPA Status: Needs Input Applied to issues in need of input from someone currently unavailable Type: Feature a feature request

Projects

Status: Ready for Review ⏩

Development

Successfully merging this pull request may close these issues.

Support applying template id in API of dataset creation and persist dataset–template associations

4 participants