fix(combo/simple-combo): prevent Escape from closing parent container on clear - master#17134
Open
georgianastasov wants to merge 3 commits intomasterfrom
Open
fix(combo/simple-combo): prevent Escape from closing parent container on clear - master#17134georgianastasov wants to merge 3 commits intomasterfrom
georgianastasov wants to merge 3 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue where pressing Escape inside igx-combo / igx-simple-combo (e.g., to clear or close the dropdown) was also bubbling up and closing a parent container like igx-dialog (overlay closeOnEscape).
Changes:
- Stop
Escapekeydown event propagation inIgxComboComponentandIgxSimpleComboComponent. - Add unit tests asserting
stopPropagation()is invoked for Escape handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.ts | Stops Escape keydown bubbling during SimpleCombo key handling to avoid parent overlay/dialog close. |
| projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.spec.ts | Adds tests verifying Escape keydown calls stopPropagation() in relevant SimpleCombo states. |
| projects/igniteui-angular/combo/src/combo/combo.component.ts | Stops Escape keydown bubbling in Combo HostListener handler to prevent parent overlay/dialog close. |
| projects/igniteui-angular/combo/src/combo/combo.component.spec.ts | Adds tests verifying Escape keydown calls stopPropagation() in relevant Combo states. |
kdinev
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17119
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)