Skip to content

fix(combo/simple-combo): prevent Escape from closing parent container on clear - master#17134

Open
georgianastasov wants to merge 3 commits intomasterfrom
ganastasov/combo-escape-close-master
Open

fix(combo/simple-combo): prevent Escape from closing parent container on clear - master#17134
georgianastasov wants to merge 3 commits intomasterfrom
ganastasov/combo-escape-close-master

Conversation

@georgianastasov
Copy link
Copy Markdown
Contributor

Closes #17119

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copilot AI review requested due to automatic review settings March 31, 2026 06:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an issue where pressing Escape inside igx-combo / igx-simple-combo (e.g., to clear or close the dropdown) was also bubbling up and closing a parent container like igx-dialog (overlay closeOnEscape).

Changes:

  • Stop Escape keydown event propagation in IgxComboComponent and IgxSimpleComboComponent.
  • Add unit tests asserting stopPropagation() is invoked for Escape handling.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.ts Stops Escape keydown bubbling during SimpleCombo key handling to avoid parent overlay/dialog close.
projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.spec.ts Adds tests verifying Escape keydown calls stopPropagation() in relevant SimpleCombo states.
projects/igniteui-angular/combo/src/combo/combo.component.ts Stops Escape keydown bubbling in Combo HostListener handler to prevent parent overlay/dialog close.
projects/igniteui-angular/combo/src/combo/combo.component.spec.ts Adds tests verifying Escape keydown calls stopPropagation() in relevant Combo states.

@georgianastasov georgianastasov requested a review from kdinev March 31, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combo/SimpleCombo: pressing Esc to clear closes Dialog

3 participants