Skip to content

fix(combo/simple-combo): prevent Escape from closing parent container on clear - 21.1.x#17135

Merged
kdinev merged 3 commits into21.1.xfrom
ganastasov/combo-escape-close-21.1.x
Apr 1, 2026
Merged

fix(combo/simple-combo): prevent Escape from closing parent container on clear - 21.1.x#17135
kdinev merged 3 commits into21.1.xfrom
ganastasov/combo-escape-close-21.1.x

Conversation

@georgianastasov
Copy link
Copy Markdown
Contributor

Closes #17119

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copilot AI review requested due to automatic review settings March 31, 2026 06:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an issue where pressing Escape in igx-combo / igx-simple-combo inside a parent container (e.g., igx-dialog) can propagate the key event and cause the parent to close while the combo is clearing/closing.

Changes:

  • Stop Escape keydown propagation in IgxComboComponent.onEscape.
  • Stop Escape keydown propagation in IgxSimpleComboComponent.handleKeyDown.
  • Add unit tests asserting stopPropagation() is invoked for Escape in relevant states.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.ts Stops Escape keydown propagation during simple-combo keyboard handling.
projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.spec.ts Adds specs asserting Escape keydown propagation is stopped.
projects/igniteui-angular/combo/src/combo/combo.component.ts Stops Escape keydown propagation in combo host listener handler.
projects/igniteui-angular/combo/src/combo/combo.component.spec.ts Adds specs asserting Escape keydown propagation is stopped.

@georgianastasov georgianastasov requested a review from kdinev March 31, 2026 08:00
@georgianastasov georgianastasov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 1, 2026
@kdinev kdinev merged commit a68d01e into 21.1.x Apr 1, 2026
5 checks passed
@kdinev kdinev deleted the ganastasov/combo-escape-close-21.1.x branch April 1, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

combo simple-combo version: 21.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants