Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue where pressing Escape in igx-combo / igx-simple-combo inside a parent container (e.g., igx-dialog) can propagate the key event and cause the parent to close while the combo is clearing/closing.
Changes:
- Stop
Escapekeydown propagation inIgxComboComponent.onEscape. - Stop
Escapekeydown propagation inIgxSimpleComboComponent.handleKeyDown. - Add unit tests asserting
stopPropagation()is invoked forEscapein relevant states.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.ts | Stops Escape keydown propagation during simple-combo keyboard handling. |
| projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.spec.ts | Adds specs asserting Escape keydown propagation is stopped. |
| projects/igniteui-angular/combo/src/combo/combo.component.ts | Stops Escape keydown propagation in combo host listener handler. |
| projects/igniteui-angular/combo/src/combo/combo.component.spec.ts | Adds specs asserting Escape keydown propagation is stopped. |
projects/igniteui-angular/simple-combo/src/simple-combo/simple-combo.component.ts
Show resolved
Hide resolved
kdinev
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17119
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)