fix(ESF): move custom dialog out of ESF markup#17136
Open
Conversation
wnvko
added
❌ status: awaiting-test
damyanpetev
reviewed
Mar 31, 2026
Comment on lines
+142
to
+148
| this._overlayService.opening.pipe(takeUntil(this.destroy$)).subscribe((args) => { | ||
| if (args.id === overlayId) { | ||
| customDialog.esf = this.esf; | ||
| customDialog.column = this.esf.column; | ||
| customDialog.filteringService = this.esf.grid.filteringService; | ||
| customDialog.overlayComponentId = overlayId; | ||
| customDialog.selectedOperator = eventArgs.newSelection.value; |
Member
There was a problem hiding this comment.
I don't see a reason for the opening here, can we have mostly the same logic as before that just assigned the customDialog props
| modal: false, | ||
| closeOnOutsideClick: true, | ||
| positionStrategy: new ContainerPositionStrategy(), | ||
| scrollStrategy: new AbsoluteScrollStrategy() |
Member
There was a problem hiding this comment.
This does.. nothing for container strategy?
| const overlayId = this._overlayService.attach(IgxExcelStyleCustomDialogComponent, this.esf.grid.viewRef, overlaySettings); | ||
| const overlayInfo = this._overlayService.getOverlayById(overlayId); | ||
| const customDialog = overlayInfo.componentRef.instance as IgxExcelStyleCustomDialogComponent; | ||
| this.esf.grid.tbody.nativeElement.appendChild(overlayInfo.wrapperElement.parentElement); |
Member
There was a problem hiding this comment.
I know this is needed atm, but we could consider leaving the dialog on the grid container instead as well (separate from the PR);
wnvko
added
🛠️ status: in-development
…hub.com/IgniteUI/igniteui-angular into mvenkov/move-esf-dialog-out-of-dropdown
wnvko
added
❌ status: awaiting-test
damyanpetev
reviewed
Mar 31, 2026
Comment on lines
163
to
+167
| if (this.esf.overlayComponentId) { | ||
| this.esf.hide(); | ||
| } | ||
| this.subMenu.close(); | ||
| this.customDialog.open(this.esf.mainDropdown.nativeElement); | ||
| this._overlayService.show(overlayId); |
Member
There was a problem hiding this comment.
I know this PR merely moves things around to remove the outlet usage, but this component can really use some refactoring where the onSubMenuSelection is emitted upwards for the root ESF component to handle, close itself and spawn the dialog. And possibly some actual dialog and/or dialog ARIA would be nice. Just 2c
damyanpetev
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the custom dialog shown in ESF is a child element of the
excel-style-conditional-filtercomponent. When custom dialog is shown its parent is closed. This makes the parent of the dialog invisible, marked withdisplay: none. This effectively hides and the dialog. To fix this custom dialog is now removed fromexcel-style-conditional-filtercomponent. Custom dialog is shown directly viaoverlayservice and is provided as component.Next step will be to remove the grid outlet used to show the custom dialog in the grid as this will not be needed anymore.
Closes #17039
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)