Skip to content

feat(*): adding jQuery deploy#101

Open
ChronosSF wants to merge 2 commits into
vkombov/migrate-jquery-docsfrom
sstoychev/jquery-deploy
Open

feat(*): adding jQuery deploy#101
ChronosSF wants to merge 2 commits into
vkombov/migrate-jquery-docsfrom
sstoychev/jquery-deploy

Conversation

@ChronosSF
Copy link
Copy Markdown
Member

and:

  • using the new actions ability to deploy to igniteui.com / jp.igniteui.com for jQuery
  • splitting the builds to allow for path-ignores to not deploy, e.g. xplat when just angular docs are changed
    • xplat cannot be filtered further as docs are shared
    • astro-related changes should trigger all deploys

…tching

Co-authored-by: Copilot <copilot@github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documentation CD pipeline to support jQuery deployments to igniteui.com and to split deployments by platform/locale so unrelated doc changes don’t trigger unnecessary deploys.

Changes:

  • Switch jQuery docs base path to /docs-jquery-new and update jQuery production/staging hosts to igniteui.com.
  • Introduce per-platform/per-locale CD entry workflows (Angular + XPlat EN/JP) that call a reusable _cd-deploy workflow.
  • Update reusable deploy workflow to accept a platform input, build/package per platform, and pass a deploy_igniteui flag for jQuery.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/platform.ts Updates jQuery/jQueryJP base path to /docs-jquery-new.
docs/jquery/astro.config.ts Switches jQuery site host to igniteui.com and continues deriving base from IGDOCS_PLATFORMS.
.github/workflows/_cd-deploy.yml Reworks reusable CD workflow to take a platform input and build/package/upload per platform.
.github/workflows/cd-xplat-en.yml New XPlat EN workflow calling reusable deploy with a platform matrix.
.github/workflows/cd-xplat-jp.yml New XPlat JP workflow calling reusable deploy with a platform matrix.
.github/workflows/cd-angular-en.yml New Angular EN workflow calling reusable deploy.
.github/workflows/cd-angular-jp.yml New Angular JP workflow calling reusable deploy.
.github/workflows/cd-jquery-en.yml Updates jQuery EN workflow to pass platform: jquery and expands paths-ignore.
.github/workflows/cd-jquery-jp.yml Updates jQuery JP workflow to pass platform: jquery and expands paths-ignore.
Comments suppressed due to low confidence (2)

.github/workflows/cd-jquery-en.yml:18

  • paths-ignore uses **/jp/**, but the jQuery JP content in this repo lives under docs/jquery/src/content/ja/ (see docs/jquery/astro.config.ts:38). As written, JP-only content changes will still trigger the EN deploy workflow. Consider ignoring **/ja/** here (and/or narrowing the ignore patterns to the actual jQuery content paths).
    docs/jquery/astro.config.ts:32
  • For DOCS_LANG=jp, site is still built from https://www.igniteui.com rather than a JP host (the PR description mentions deploying to jp.igniteui.com). Since site is used by Astro for canonical URLs and absolute link generation, consider switching the host based on docsLang (e.g., www.igniteui.com vs jp.igniteui.com) and also ensuring productLinks uses the same per-locale host.
const PROD_HOST = 'https://www.igniteui.com';
const STAGING_HOST = 'https://staging.igniteui.com';

// jp.infragistics.com is the JP domain; the base path is the same as en.
const platformKey = docsLang === 'jp' ? 'jQueryJP' : 'jQuery';
const { base } = IGDOCS_PLATFORMS[platformKey];
const site = mode === 'production' ? `${PROD_HOST}${base}`
	: mode === 'staging' ? `${STAGING_HOST}${base}`
	: 'http://localhost:4335';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- name: Build Documentation for ${{ matrix.platform }} (${{ inputs.locale }})
run: npm run build:${{ env.BUILD_TYPE }}:${{ matrix.platform }}:${{ inputs.locale }}
- name: Build Documentation for ${{ inputs.platform }} (${{ inputs.locale }})
run: npm run build:${{ env.BUILD_TYPE }}:${{ inputs.platform }}:${{ inputs.locale }}
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build command here expects root-level scripts named build:<BUILD_TYPE>:<platform>:<locale>, but the repo only defines jQuery scripts as jquery:build-* (e.g. jquery:build-staging:en in package.json). With platform: jquery passed by the jQuery workflows, this step will fail because build:staging:jquery:en/jp is not defined. Consider either adding matching build:staging:jquery:* scripts at the root, or branching in the workflow to call the existing jquery:build-* scripts when inputs.platform == 'jquery'.

Suggested change
run: npm run build:${{ env.BUILD_TYPE }}:${{ inputs.platform }}:${{ inputs.locale }}
run: |
if [ "${{ inputs.platform }}" = "jquery" ]; then
npm run jquery:build-${{ env.BUILD_TYPE }}:${{ inputs.locale }}
else
npm run build:${{ env.BUILD_TYPE }}:${{ inputs.platform }}:${{ inputs.locale }}
fi

Copilot uses AI. Check for mistakes.
Comment on lines +42 to 46
- name: Setup Node.js 24.x
uses: actions/setup-node@v6
with:
node-version: '22.x'
node-version: '24.x'

Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow pins Node.js to 24.x, but the repo’s CI uses Node 22 (see .github/workflows/ci.yml:22-25) and package.json declares engines.node >=22.12.0. To avoid deploy-only failures or differing build output vs CI, consider using the same Node major as CI (or update CI/engines in the same PR to match).

Copilot uses AI. Check for mistakes.
Comment on lines +35 to 44
uses: actions/checkout@v6
with:
ref: ${{ inputs.target_ref }}
clean: true
fetch-tags: true
fetch-depth: 0

- name: Setup Node.js 22.x
uses: actions/setup-node@v4
- name: Setup Node.js 24.x
uses: actions/setup-node@v6
with:
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout@v6 / actions/setup-node@v6 are inconsistent with the rest of the repo (CI uses @v4 for both in .github/workflows/ci.yml:20-25). If this isn’t an intentional upgrade across all workflows, consider keeping these aligned to reduce maintenance and unexpected behavior differences between CI and CD.

Copilot uses AI. Check for mistakes.
const PROD_HOST = 'https://www.igniteui.com';
const STAGING_HOST = 'https://staging.igniteui.com';

// jp.infragistics.com is the JP domain; the base path is the same as en.
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment about jp.infragistics.com being the JP domain is now out of date since this config switched to igniteui.com hosts. Updating/removing it would avoid confusion for future maintainers (especially since jQuery JP content uses the ja/ folder while DOCS_LANG is jp).

Suggested change
// jp.infragistics.com is the JP domain; the base path is the same as en.
// JP builds use the 'jQueryJP' platform entry to resolve the correct base path;
// production/staging hosts are shared igniteui.com domains for all languages.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants