Skip to content

fix(getting-started): fixes for the node/vs code download banners#206

Merged
ChronosSF merged 2 commits into
masterfrom
sstoychev/fix-node-vscode-banners
May 22, 2026
Merged

fix(getting-started): fixes for the node/vs code download banners#206
ChronosSF merged 2 commits into
masterfrom
sstoychev/fix-node-vscode-banners

Conversation

@ChronosSF
Copy link
Copy Markdown
Member

@ChronosSF ChronosSF commented May 22, 2026

Closes #201

Main issues were:

  • multiline anchor text is wrapped by p's by remark for mdx .This can be solved differently but in the interest of not complicating this, I preferred just fixing the block.
  • the new design uses margin-bottom to add spaces between elements so we had to do that for the block too.

@ChronosSF ChronosSF requested a review from dobromirts May 22, 2026 13:51
@ChronosSF ChronosSF added the ❌ status: awaiting-test PRs awaiting manual verification label May 22, 2026
@dobromirts dobromirts added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 22, 2026
@dobromirts dobromirts added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels May 22, 2026
@ChronosSF ChronosSF merged commit 9d3a8b7 into master May 22, 2026
7 checks passed
@ChronosSF ChronosSF deleted the sstoychev/fix-node-vscode-banners branch May 22, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting started images of node and vscode are a bit off

2 participants