fix(pwd): guard against empty index when erasing from glob in _tide_p…#630
Open
micahkepe wants to merge 1 commit intoIlanCosman:mainfrom
Open
fix(pwd): guard against empty index when erasing from glob in _tide_p…#630micahkepe wants to merge 1 commit intoIlanCosman:mainfrom
micahkepe wants to merge 1 commit intoIlanCosman:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an error in
_tide_pwdwhereset -e glob[(contains -i ...)]could be evaluated with an empty index.When
contains -ifails to find a match, it produces no output, causing Fish to evaluateset -e glob[]and throw:This change guards the erase operation so it only occurs when a valid index is returned, preserving existing behavior while preventing the error.
Motivation and Context
This error can occur during path truncation when the computed
$globlist does not contain an exact match for the current directory (e.g. due to path normalization, trailing slashes, or filesystem state).Guarding the erase avoids a hard failure in the prompt while keeping the truncation logic unchanged when a match exists.
Closes #598
Screenshots (if appropriate)
N/A
How Has This Been Tested
Checklist
(Not applicable — internal bugfix, no user-facing changes)
(No existing test coverage for prompt rendering logic)