LiveScene: Support point-based geometry in readObject#1532
Open
jaec-ie wants to merge 3 commits into
Open
Conversation
The previous check only handled eParticlesSprite with exactly one primitive, which missed point geometry from nodes like DeepToPoints that output eParticles primitives. This caused the points to be routed through MeshFromNuke, producing a broken empty mesh that didn't render in Caribou/Gaffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally describe what this PR will do, and why it is needed.
DeepToPointsnode outputseParticlestype primitives, whichLiveScene::readObject()did not recognize as point geometry. The previous check only matchedeParticlesSprite, causing DeepToPoints output to fall through toMeshFromNuke.eParticlesSpriterepresent a collection of particles in one primitive, but output ofDeepToPointscould be N primitives, now checking if primitives > 0.Related Issues
Dependencies
Breaking Changes
Checklist