IECoreGL : Restore CurvesPrimitive OpenGL 2.1 compatibility#1534
Open
murraystevenson wants to merge 2 commits into
Open
IECoreGL : Restore CurvesPrimitive OpenGL 2.1 compatibility#1534murraystevenson wants to merge 2 commits into
murraystevenson wants to merge 2 commits into
Conversation
This isn't ideal, but will allow the OpenGL Scene Viewer in Gaffer 1.7 to continue to work on macOS.
These were added with the conversion to raw string literals in cab67a2 and lead to syntax errors when the shaders are compiled on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GL shader adjustments in #1526 bumped
Shader::defaultVertexSource()to requiring OpenGL 3.2 Compatibility Profile, which is not supported on macOS. This PR adds a workaround to maintain support with GL 2.1 with a todo to revert it once we can target a more modern OpenGL version supported by all platforms...