Replace platform-specific SIMD with portable wide crate #127
+68
−93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
f_pixel::diff()with portablewide::f32x4HistSortTmpunion in favor of plainu32(union was unnecessary sincePalIndexfits inu32)get_uncheckedinqsort_pivot(3 bounds checks is negligible overhead)Details
The
diff()function had three separate implementations using unsafe intrinsics:#[cfg(target_arch = "x86_64")]with SSE2#[cfg(target_arch = "aarch64")]with NEONNow there's a single portable implementation using
wide::f32x4that compiles to equivalent SIMD on both architectures. A scalar reference implementation is retained under#[cfg(test)]with a brute-force comparison test that verifies both implementations match across edge cases.Test plan
diff_simd_matches_scalartest verifies SIMD matches scalar referencecargo clippypasses