fix(tests): skip crashing torch ops on ascend#614
Draft
zhangyue207 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonzeroandmse_lossto the Ascend vendor crash skip list intests/test_torch_ops.py.Motivation
The Ascend full CI sweep can crash inside the
torch_npupath for these generated torch-op cases after many preceding tests have run. Focused runs are not consistently failing, which points to a vendor runtime state issue rather than a deterministic InfiniOps operator regression.Closes #
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResult3375 passed, 4811 skipped, 40 warnings in 57.13sinfiniops-ci/ascend:669bca8,pytest tests/ -n 1 --devices ascend -v --tb=short.Full `pytest` output (optional)
Benchmark / Performance Impact
N/A.
Notes for Reviewers
This uses the existing
_VENDOR_CRASH_OPSmechanism for vendor-runtime crashes intests/test_torch_ops.py. A first full sweep with onlynonzeroskipped progressed pastnonzeroand then failed atmse_loss; skipping both allowed the full Ascend sweep to complete with no JUnit failures.Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).C++ Specific (if C++ files changed)
N/A — no C++ files changed.
Python Specific (if Python files changed)
ruff check tests/test_torch_ops.pypasses cleanly.ruff format --check tests/test_torch_ops.pypasses cleanly.returnspacing was changed.Testing
pytestwas run locally on every supported platform that this PR can affect, and the results are recorded in the "Test Results" table above (CONTRIBUTING.md§Pull Requests).Payloadtests were added or changed.dtype/deviceparameterization was added or changed.masteratnonzeroormse_lossand passes with this PR.Build, CI, and Tooling
pip install .[dev]on Ascend.compile_commands.jsonregeneration was exercised by the local CI wrapper build.ruff check tests/test_torch_ops.py,ruff format --check tests/test_torch_ops.py, andgit diff --checkpass locally.Documentation
Security and Safety