fix(scripts): apply regex fallback in dispatch entries generation#620
Open
fuyou4546 wants to merge 1 commit into
Open
fix(scripts): apply regex fallback in dispatch entries generation#620fuyou4546 wants to merge 1 commit into
fuyou4546 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_generate_pybind11()into_generate_generated_dispatch_entries()inscripts/generate_wrappers.py.std::vector<Tensor>,std::optional<Tensor>,std::vector<int64_t>) even whenlibclangsilently downgrades them toint.Motivation
_generate_pybind11()already falls back to regex scans whenlibclangsilently downgradesstd::vector<Tensor>,std::optional<Tensor>, andstd::vector<int64_t>tointonenvironments with incomplete STL header indexing. The dispatch
generator did not, so it emitted
int rest_inputswhile the pybindlayer used
std::vector<Tensor> rest_inputs, breaking the build with atype-mismatch error.
Closes #
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResultFull `pytest` output (optional)
Benchmark / Performance Impact
N/A
Notes for Reviewers
The new logic in
_generate_generated_dispatch_entries()is a directmirror of the existing fallback in
_generate_pybind11()(same three_find_*helpers, same_is_*predicate style). The only divergenceis that the dispatch layer keeps native C++ types (
Tensor) ratherthan substituting
py::object, because it forwards directly toOperator<Op>::Make(...). The trigger is environmental and notconsistently reproducible across setups (works fine in the project's
Docker image), so mirroring the existing precedent keeps the patch
minimal and avoids per-environment investigation.
Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).C++ Specific (if C++ files changed)
Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).Testing
pytestwas run locally on every supported platform that this PR can affect, and the results are recorded in the "Test Results" table above (CONTRIBUTING.md§Pull Requests).Payloadtests were added or changed.dtype/deviceparameterization was added or changed.pip install .succeeds in the affected conda environment with this PR, and fails on master with the type-mismatch error quoted in "Motivation".Build, CI, and Tooling
pip install .[dev]on at least one affected platform.compile_commands.jsonstill regenerates (CMake optionCMAKE_EXPORT_COMPILE_COMMANDS=ONinpyproject.toml— required by thecode-lintskill andclang-tidy -p).ruff check scripts/generate_wrappers.pyandruff format --check scripts/generate_wrappers.pypass locally.Documentation
Security and Safety